Skip to content

Commit 630ee6a

Browse files
committed
feat: build output objects separately
1 parent 0048a41 commit 630ee6a

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

R/tm_g_distribution.R

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1305,40 +1305,40 @@ srv_distribution <- function(id,
13051305
expr = print(qq_plot)
13061306
)
13071307

1308-
decorated_output_q_base <- reactive({
1309-
tab <- req(input$tabs) # tab is NULL upon app launch, hence will crash without this statement
1310-
if (tab == "Histogram") {
1311-
decorated_output_dist_q()
1312-
} else if (tab == "QQplot") {
1313-
decorated_output_qq_q()
1314-
}
1315-
})
1316-
1317-
decorated_output_q_summary <- srv_decorate_teal_data(
1308+
decorated_output_summary_q <- srv_decorate_teal_data(
13181309
"d_summary",
1319-
data = decorated_output_q_base,
1310+
data = output_common_q,
13201311
decorators = select_decorators(decorators, "summary_table"),
13211312
expr = summary_table
13221313
)
13231314

1324-
decorated_output_q <- srv_decorate_teal_data(
1315+
decorated_output_test_q <- srv_decorate_teal_data(
13251316
"d_test",
1326-
data = decorated_output_q_summary,
1317+
data = output_common_q,
13271318
decorators = select_decorators(decorators, "test_table"),
13281319
expr = test_table
13291320
)
13301321

1322+
decorated_output_q <- reactive({
1323+
tab <- req(input$tabs) # tab is NULL upon app launch, hence will crash without this statement
1324+
if (tab == "Histogram") {
1325+
c(decorated_output_dist_q(), decorated_output_summary_q(), decorated_output_test_q())
1326+
} else if (tab == "QQplot") {
1327+
c(decorated_output_qq_q(), decorated_output_summary_q(), decorated_output_test_q())
1328+
}
1329+
})
1330+
13311331
dist_r <- reactive(req(decorated_output_dist_q())[["histogram_plot"]])
13321332

13331333
qq_r <- reactive(req(decorated_output_qq_q())[["qq_plot"]])
13341334

1335-
output$summary_table <- DT::renderDataTable(expr = decorated_output_q()[["summary_table"]])
1335+
output$summary_table <- DT::renderDataTable(expr = decorated_output_summary_q()[["summary_table"]])
13361336

13371337
tests_r <- reactive({
13381338
req(iv_r()$is_valid())
13391339
teal::validate_inputs(iv_r_dist())
13401340
req(test_q()) # Ensure original errors are displayed
1341-
decorated_output_q()[["test_table"]]
1341+
decorated_output_test_q()[["test_table"]]
13421342
})
13431343

13441344
pws1 <- teal.widgets::plot_with_settings_srv(

0 commit comments

Comments
 (0)