Skip to content

Commit b0d556a

Browse files
authored
Merge branch '1187_decorate_output@main' into tm_g_distribution@1187_decorate_output@main
2 parents 2268716 + 1c10233 commit b0d556a

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

R/tm_a_regression.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
#'
4545
#' @section Decorating `tm_a_regression`:
4646
#'
47-
#' This module creates below objects that can be modified with decorators:
47+
#' This module generates the following objects, which can be modified in place using decorators:
4848
#' - `plot` (`ggplot2`)
4949
#'
5050
#' For additional details and examples of decorators, refer to the vignette
@@ -1062,7 +1062,7 @@ srv_a_regression <- function(id,
10621062
card$append_text("Comment", "header3")
10631063
card$append_text(comment)
10641064
}
1065-
card$append_src(teal.code::get_code(output_q()))
1065+
card$append_src(teal.code::get_code(req(output_q())))
10661066
card
10671067
}
10681068
teal.reporter::simple_reporter_srv("simple_reporter", reporter = reporter, card_fun = card_fun)

R/tm_outliers.R

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
#'
3030
#' @section Decorating `tm_outliers`:
3131
#'
32-
#' This module creates below objects that can be modified with decorators:
32+
#' This module generates the following objects, which can be modified in place using decorators:
3333
#' - `table` (`data.frame`)
3434
#' - `plot` (`ggplot2`)
3535
#'
@@ -984,6 +984,7 @@ srv_outliers <- function(id, data, reporter, filter_panel_api, outlier_var,
984984

985985
decorated_boxplot_q <- srv_teal_transform_data("boxplot_decorator", data = boxplot_q, transformators = decorators$boxplot)
986986
decorated_violin_q <- srv_teal_transform_data("violin_decorator", data = boxplot_q, transformators = decorators$violin)
987+
# TODO decorated_violin_q is not used anywhere
987988
decorated_density_plot_q <- srv_teal_transform_data("density_decorator", data = density_plot_q, transformators = decorators$density)
988989
decorated_cumulative_plot_q <- srv_teal_transform_data("cum_dist_decorator", data = cumulative_plot_q, transformators = decorators$cum_dist)
989990

@@ -1020,8 +1021,7 @@ srv_outliers <- function(id, data, reporter, filter_panel_api, outlier_var,
10201021

10211022
decorated_final_q <-
10221023
srv_teal_transform_data("cum_dist_decorator", data = final_q, transformators = decorators$table_decorator)
1023-
# TODO:
1024-
# reuse decorated_final_q in table generation
1024+
# TODO: reuse decorated_final_q in table generation
10251025

10261026
# slider text
10271027
output$ui_outlier_help <- renderUI({
@@ -1301,7 +1301,7 @@ srv_outliers <- function(id, data, reporter, filter_panel_api, outlier_var,
13011301
card$append_text("Comment", "header3")
13021302
card$append_text(comment)
13031303
}
1304-
card$append_src(teal.code::get_code(final_q()))
1304+
card$append_src(teal.code::get_code(req(final_q())))
13051305
card
13061306
}
13071307
teal.reporter::simple_reporter_srv("simple_reporter", reporter = reporter, card_fun = card_fun)

man/tm_a_regression.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/tm_outliers.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)