Skip to content

Commit ba2b037

Browse files
committed
Shorter datasets_selected argument and remove the datanames' argument of srv_page_data_table
1 parent 2da5d0b commit ba2b037

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

R/tm_data_table.R

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@
1717
#' If no entry is specified for a dataset, the first six variables from that
1818
#' dataset will initially be shown.
1919
#' @param datasets_selected (`character`) `r lifecycle::badge("deprecated")` A vector of datasets which should be
20-
#' shown and in what order. Names in the vector have to correspond with datasets names.
21-
#' If vector of `length == 0` (default) then all datasets are shown.
22-
#' Note: Only datasets of the `data.frame` class are compatible.
20+
#' shown and in what order. Use `datanames` instead.
2321
#' @param dt_args (`named list`) Additional arguments to be passed to [DT::datatable()]
2422
#' (must not include `data` or `options`).
2523
#' @param dt_options (`named list`) The `options` argument to `DT::datatable`. By default
@@ -139,7 +137,6 @@ tm_data_table <- function(label = "Data Table",
139137
datanames = datanames,
140138
server_args = list(
141139
variables_selected = variables_selected,
142-
datanames = datanames,
143140
dt_args = dt_args,
144141
dt_options = dt_options,
145142
server_rendering = server_rendering
@@ -188,7 +185,6 @@ ui_page_data_table <- function(id, pre_output = NULL, post_output = NULL) {
188185
# Server page module
189186
srv_page_data_table <- function(id,
190187
data,
191-
datanames,
192188
variables_selected,
193189
dt_args,
194190
dt_options,
@@ -206,10 +202,6 @@ srv_page_data_table <- function(id,
206202
is.data.frame(isolate(data())[[name]])
207203
}, datanames)
208204

209-
if (!identical(datanames, character(0))) {
210-
checkmate::assert_subset(datanames, datanames)
211-
}
212-
213205
output$dataset_table <- renderUI({
214206
do.call(
215207
tabsetPanel,

0 commit comments

Comments
 (0)