Skip to content

Commit e466ee7

Browse files
committed
Make the reporter work
1 parent 2a740c4 commit e466ee7

File tree

1 file changed

+14
-18
lines changed

1 file changed

+14
-18
lines changed

R/tm_variable_browser.R

Lines changed: 14 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,7 @@ srv_variable_browser <- function(id,
458458
outlier_definition <- 0
459459
}
460460

461-
pvs <- plot_var_summary(
461+
plot_var_summary(
462462
qenv = plotted_data(),
463463
# var = plotted_data()$data,
464464
# var_lab = plotted_data()$var_description,
@@ -470,10 +470,10 @@ srv_variable_browser <- function(id,
470470
records_for_factor = .unique_records_for_factor,
471471
ggplot2_args = all_ggplot2_args()
472472
)
473-
pvs
474473
})
475474

476475
plot_r <- reactive({
476+
validation_checks()
477477
req(variable_plot_r())[["plot"]]
478478
})
479479

@@ -497,12 +497,7 @@ srv_variable_browser <- function(id,
497497
)
498498
})
499499

500-
output_q <- reactive({
501-
validation_checks()
502-
qenv <- req(variable_plot_r())
503-
teal.reporter::as.teal_card(qenv)
504-
})
505-
set_chunk_dims(pws, output_q)
500+
set_chunk_dims(pws, variable_plot_r)
506501
})
507502
}
508503

@@ -629,16 +624,13 @@ var_summary_table <- function(x, numeric_as_factor, dt_rows, outlier_definition)
629624
#' @return plot
630625
#' @keywords internal
631626
plot_var_summary <- function(qenv,
632-
# var,
633-
# var_lab,
634627
wrap_character = NULL,
635628
numeric_as_factor,
636629
display_density = FALSE,
637630
remove_NA_hist = FALSE, # nolint: object_name.
638631
outlier_definition,
639632
records_for_factor,
640633
ggplot2_args) {
641-
# checkmate::assert_character(var_lab)
642634
checkmate::assert_numeric(wrap_character, null.ok = TRUE)
643635
checkmate::assert_flag(numeric_as_factor)
644636
checkmate::assert_flag(display_density)
@@ -649,7 +641,8 @@ plot_var_summary <- function(qenv,
649641

650642
var_name <- names(qenv$ANL)
651643

652-
teal.reporter::teal_card(qenv) <- c(teal.reporter::teal_card(qenv), "### Plot")
644+
teal.reporter::teal_card(qenv) <- c(teal.reporter::teal_card(qenv),
645+
teal.reporter::teal_card("### Histogram plot"))
653646

654647
var <- qenv$ANL[[var_name]]
655648
qenv_plot <- if (is.factor(var) || is.character(var) || is.logical(var)) {
@@ -871,17 +864,20 @@ validate_input <- function(input, plot_var, data) {
871864
get_plotted_data <- function(input, plot_var, data) {
872865
dataset_name <- req(input$tabset_panel)
873866
varname <- plot_var$variable[[dataset_name]]
874-
q <- within(data(), {
867+
obj <- data()
868+
teal.reporter::teal_card(obj) <-
869+
c(
870+
teal.reporter::teal_card(obj),
871+
teal.reporter::teal_card("## Module's output(s)")
872+
)
873+
within(obj, {
875874
library(dplyr)
876-
ANL <- dataset_name %>%
877-
select(varname)
875+
library(ggplot2)
876+
ANL <- select(dataset_name, varname)
878877
},
879878
dataset_name = as.name(dataset_name),
880879
varname = as.name(varname)
881880
)
882-
# var_description <- teal.data::col_labels(df)[[varname]]
883-
# list(data = df[[varname]], var_description = var_description)
884-
q
885881
}
886882

887883
#' Renders the left-hand side `tabset` panel of the module

0 commit comments

Comments
 (0)