Skip to content

Commit e8dc0e8

Browse files
authored
Merge pull request #871 from insightsengineering/870-hot-fix@to-cran
[skip vbump] [skip actions] Hot fix - upversion v0.4.1
2 parents d3e9699 + 9395313 commit e8dc0e8

File tree

10 files changed

+35
-29
lines changed

10 files changed

+35
-29
lines changed

DESCRIPTION

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
Type: Package
22
Package: teal.modules.general
33
Title: General Modules for 'teal' Applications
4-
Version: 0.4.0.9001
5-
Date: 2025-03-11
4+
Version: 0.4.1.9000
5+
Date: 2025-04-01
66
Authors@R: c(
77
person("Dawid", "Kaledkowski", , "[email protected]", role = c("aut", "cre")),
88
person("Pawel", "Rucki", , "[email protected]", role = "aut"),

NEWS.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
1-
# teal.modules.general 0.4.0.9001
1+
# teal.modules.general 0.4.1.9000
2+
3+
# teal.modules.general 0.4.1
4+
5+
### Bug fixes
6+
* Fixes output is not updated when filter is added for the modules: `tm_a_pca`, `tm_a_regression`, `tm_g_scatterplot`, `tm_g_association`, `tm_g_bivariate`, `tm_g_distribution`, `tm_g_response`, `tm_t_crosstable` (#870)
27

38
# teal.modules.general 0.4.0
49

R/tm_a_pca.R

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -436,10 +436,12 @@ srv_a_pca <- function(id, data, reporter, filter_panel_api, dat, plot_height, pl
436436
selector_list = selector_list,
437437
datasets = data
438438
)
439-
qenv <- teal.code::eval_code(data(), 'library("ggplot2");library("dplyr");library("tidyr")') # nolint quotes
439+
qenv <- reactive(
440+
teal.code::eval_code(data(), 'library("ggplot2");library("dplyr");library("tidyr")') # nolint quotes
441+
)
440442
anl_merged_q <- reactive({
441443
req(anl_merged_input())
442-
qenv %>%
444+
qenv() %>%
443445
teal.code::eval_code(as.expression(anl_merged_input()$expr))
444446
})
445447

R/tm_a_regression.R

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -462,14 +462,13 @@ srv_a_regression <- function(id,
462462
)
463463
})
464464

465-
qenv <- teal.code::eval_code(
466-
data(),
467-
'library("ggplot2");library("dplyr")' # nolint quotes
465+
qenv <- reactive(
466+
teal.code::eval_code(data(), 'library("ggplot2");library("dplyr")') # nolint quotes
468467
)
469468

470469
anl_merged_q <- reactive({
471470
req(anl_merged_input())
472-
qenv %>%
471+
qenv() %>%
473472
teal.code::eval_code(as.expression(anl_merged_input()$expr))
474473
})
475474

R/tm_g_association.R

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -346,13 +346,12 @@ srv_tm_g_association <- function(id,
346346
selector_list = selector_list
347347
)
348348

349-
qenv <- teal.code::eval_code(
350-
data(),
351-
'library("ggplot2");library("dplyr");library("tern");library("ggmosaic")' # nolint quotes
349+
qenv <- reactive(
350+
teal.code::eval_code(data(), 'library("ggplot2");library("dplyr");library("tern");library("ggmosaic")') # nolint quotes
352351
)
353352
anl_merged_q <- reactive({
354353
req(anl_merged_input())
355-
qenv %>% teal.code::eval_code(as.expression(anl_merged_input()$expr))
354+
qenv() %>% teal.code::eval_code(as.expression(anl_merged_input()$expr))
356355
})
357356

358357
merged <- list(

R/tm_g_bivariate.R

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -559,14 +559,13 @@ srv_g_bivariate <- function(id,
559559
selector_list = selector_list,
560560
datasets = data
561561
)
562-
qenv <- teal.code::eval_code(
563-
data(),
564-
'library("ggplot2");library("dplyr");library("teal.modules.general")' # nolint quotes
562+
qenv <- reactive(
563+
teal.code::eval_code(data(), 'library("ggplot2");library("dplyr");library("teal.modules.general")') # nolint quotes
565564
)
566565

567566
anl_merged_q <- reactive({
568567
req(anl_merged_input())
569-
qenv %>%
568+
qenv() %>%
570569
teal.code::eval_code(as.expression(anl_merged_input()$expr))
571570
})
572571

R/tm_g_distribution.R

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -541,14 +541,13 @@ srv_distribution <- function(id,
541541
datasets = data
542542
)
543543

544-
qenv <- teal.code::eval_code(
545-
data(),
546-
'library("ggplot2");library("dplyr")' # nolint quotes
544+
qenv <- reactive(
545+
teal.code::eval_code(data(), 'library("ggplot2");library("dplyr")') # nolint quotes
547546
)
548547

549548
anl_merged_q <- reactive({
550549
req(anl_merged_input())
551-
qenv %>%
550+
qenv() %>%
552551
teal.code::eval_code(as.expression(anl_merged_input()$expr))
553552
})
554553

R/tm_g_response.R

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -394,14 +394,13 @@ srv_g_response <- function(id,
394394
datasets = data
395395
)
396396

397-
qenv <- teal.code::eval_code(
398-
data(),
399-
'library("ggplot2");library("dplyr")' # nolint quotes
397+
qenv <- reactive(
398+
teal.code::eval_code(data(), 'library("ggplot2");library("dplyr")') # nolint quotes
400399
)
401400

402401
anl_merged_q <- reactive({
403402
req(anl_merged_input())
404-
qenv %>%
403+
qenv() %>%
405404
teal.code::eval_code(as.expression(anl_merged_input()$expr))
406405
})
407406

R/tm_g_scatterplot.R

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -590,11 +590,13 @@ srv_g_scatterplot <- function(id,
590590
datasets = data,
591591
merge_function = "dplyr::inner_join"
592592
)
593-
qenv <- teal.code::eval_code(data(), 'library("ggplot2");library("dplyr")') # nolint quotes
593+
qenv <- reactive(
594+
teal.code::eval_code(data(), 'library("ggplot2");library("dplyr")') # nolint quotes
595+
)
594596

595597
anl_merged_q <- reactive({
596598
req(anl_merged_input())
597-
qenv %>%
599+
qenv() %>%
598600
teal.code::eval_code(as.expression(anl_merged_input()$expr)) %>%
599601
teal.code::eval_code(quote(ANL)) # used to display table when running show-r-code code
600602
})

R/tm_t_crosstable.R

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -315,10 +315,12 @@ srv_t_crosstable <- function(id, data, reporter, filter_panel_api, label, x, y,
315315
selector_list = selector_list,
316316
merge_function = merge_function
317317
)
318-
qenv <- teal.code::eval_code(data(), 'library("rtables");library("tern");library("dplyr")') # nolint quotes
318+
qenv <- reactive(
319+
teal.code::eval_code(data(), 'library("rtables");library("tern");library("dplyr")') # nolint quotes
320+
)
319321
anl_merged_q <- reactive({
320322
req(anl_merged_input())
321-
qenv %>%
323+
qenv() %>%
322324
teal.code::eval_code(as.expression(anl_merged_input()$expr))
323325
})
324326

0 commit comments

Comments
 (0)