tm_missing_data reporting issues

[nikolas-burkoff]

From #469

• The report card doesn't actually say what dataset is being considered - maybe this extra line could be added in

• Is this what we want? Especially because when we reorder the table on-screen - it does not take the reorder into account when adding the tibble to the report card (should it?)

[donyunardi]

The report card doesn't actually say what dataset is being considered - maybe this extra line could be added in

I agree. The card should have the dataset name since we're dealing with multiple dataset.
@kumamiao do you agree with this?

Is this what we want? Especially because when we reorder the table on-screen - it does not take the reorder into account when adding the tibble to the report card (should it?)

Good finding about reordering not being retain during the card addition. Since this is for missing data, I don't think the reorder matters as long as it shows the missing results. It would be great though if the card can also retain the reorder happened on-screen.
@kumamiao what do you think?

I also think these issues should be in backlog.

[mhallal1]

The first point is a one liner fix, the second point is probably because the table is a DT table, adopt table_with_settings maybe?

[kumamiao]

If the first point is a one liner fix, would be great to go ahead and address it in the UAT if feasible. I'm okay with putting the second into the backlog for next release if it's not that straightforward to fix.

[donyunardi]

For the first issue, I'm fine with pushing the fix during UAT if the risk is minimal.

Are we thinking about updating the card name and the content, or just the content?
@kumamiao can you give an input on how we should mention the dataset name? Would it be the same line with the title or should it be a new line, etc?

[mhallal1]

First issue is addressed here: #473

[nikolas-burkoff]

Moving second item to backlog

[chlebowa]

Acceptance criteria:
Ensure the table in the report reflects the state of the table in the app, including user-directed sorting.
Make sure to include sorting by missing values.

[donyunardi]

As discussed with @kumamiao, we don't need to have the report reflects the user-directed sorting.
Closing.