Skip to content

[Question]: Do we need the default in the decorators? #845

@vedhav

Description

@vedhav

What is your question?

It is not easy to comprehend what they do, and the default behavior of them is not what I would expect.

  1. The tm_g_distribution says that default decorators can be applied to all outputs but two objects are of ggplot2 class and other two are of listing_df class. Even in tm_a_pca where all the output objects are ggplot2 objects I would have to use if exists and the object name to apply the plot modification because each object is enclosed in its own qenv.
  2. If I try to apply the the decorator as "default" it creates multiple UI for each of the output objects which is not the general intention for people who want to create a single decorator for all objects. Think of it as creating a decorator to change background color for all the plots. I don't want to have 4 color inputs, I just want one that is applied to all plots. If I wanted 4 color inputs, I can create 4 decorators. # of decorators = # of UI created.

So, I believe we should always allow the users to target the decoration to specific objects. If the decorator list is unnamed/default named, we will still create only one UI and server I see this is not possible because we need to target decoration to specific qenv object, so I propose we don't have it at all. What do you think @insightsengineering/nest-core-dev?

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.

Metadata

Metadata

Assignees

Labels

corequestionFurther information is requested

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions