Skip to content

Conversation

@averissimo
Copy link
Contributor

@averissimo averissimo commented Jul 25, 2025

Pull Request

Changes description

  • Annotation plotted only once
  • Correct expression
image

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2025

Unit Tests Summary

  1 files  22 suites   1s ⏱️
142 tests 29 ✅ 113 💤 0 ❌
180 runs  67 ✅ 113 💤 0 ❌

Results for commit e8c58d9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2025

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ---------------------------------------
R/tm_a_pca.R                    889     889  0.00%    139-1161
R/tm_a_regression.R             771     771  0.00%    178-1054
R/tm_data_table.R               200     200  0.00%    100-348
R/tm_file_viewer.R              172     172  0.00%    47-254
R/tm_front_page.R               143     132  7.69%    77-246
R/tm_g_association.R            345     345  0.00%    159-579
R/tm_g_bivariate.R              699     435  37.77%   331-827, 868, 979, 996, 1014, 1025-1047
R/tm_g_distribution.R          1128    1128  0.00%    156-1432
R/tm_g_response.R               370     370  0.00%    177-626
R/tm_g_scatterplot.R            735     735  0.00%    260-1099
R/tm_g_scatterplotmatrix.R      298     279  6.38%    198-533, 594, 608
R/tm_missing_data.R            1119    1119  0.00%    124-1420
R/tm_outliers.R                1062    1062  0.00%    163-1380
R/tm_t_crosstable.R             286     286  0.00%    175-519
R/tm_variable_browser.R         803     798  0.62%    89-1046, 1084-1267
R/utils.R                       144     128  11.11%   87-249, 279-315, 327-336, 341, 355-374
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          9166    8851  3.44%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  --------
R/tm_a_regression.R       -3      -3  +100.00%
TOTAL                     -3      -3  +0.00%

Results for commit: e8c58d9

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@m7pr
Copy link
Contributor

m7pr commented Aug 5, 2025

Confirming the fix works

image

Tested with

# start in teal directory
devtools::load_all("../teal.code")
devtools::load_all("../teal.data")
devtools::load_all("../teal.transform")
devtools::load_all("../teal.logger")
devtools::load_all("../teal.reporter")
devtools::load_all("../teal.widgets")
devtools::load_all(".") # getwd() -> teal
devtools::load_all("../teal.modules.general")

# general data example
data <- teal_data()
data <- within(data, {
  require(nestcolor)
  CO2 <- CO2
})

app <- init(
  data = data,
  modules = modules(
    tm_a_regression(
      label = "Regression",
      response = data_extract_spec(
        dataname = "CO2",
        select = select_spec(
          label = "Select variable:",
          choices = "uptake",
          selected = "uptake",
          multiple = FALSE,
          fixed = TRUE
        )
      ),
      regressor = data_extract_spec(
        dataname = "CO2",
        select = select_spec(
          label = "Select variables:",
          choices = variable_choices(data[["CO2"]], c("conc", "Treatment")),
          selected = "conc",
          multiple = TRUE,
          fixed = FALSE
        )
      )
    )
  )
)
if (interactive()) {
  shinyApp(app$ui, app$server)
}

@m7pr m7pr self-assigned this Aug 5, 2025
@averissimo averissimo merged commit a45791a into main Aug 5, 2025
26 checks passed
@averissimo averissimo deleted the 901-fix_annotation branch August 5, 2025 11:28
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Badly formed annotation being displayed in tm_a_regression plot

3 participants