Skip to content

Conversation

@llrs-roche
Copy link
Contributor

Pull Request

Continuation of #933

Removing ggmosaic usage on main too.

I increased the version number too to avoid issues when loading the devel version being lower than the released one.

@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -------------------------------------------
R/tm_a_pca.R                    865     865  0.00%    141-1133
R/tm_a_regression.R             751     751  0.00%    180-1027
R/tm_data_table.R               201     201  0.00%    100-348
R/tm_file_viewer.R              172     172  0.00%    47-254
R/tm_front_page.R               143     132  7.69%    77-246
R/tm_g_association.R            320     320  0.00%    161-547
R/tm_g_bivariate.R              664     406  38.86%   332-786, 827, 932, 949, 967, 978-1000
R/tm_g_distribution.R          1106    1106  0.00%    156-1404
R/tm_g_response.R               345     345  0.00%    179-594
R/tm_g_scatterplot.R            709     709  0.00%    261-1065
R/tm_g_scatterplotmatrix.R      272     253  6.99%    200-501, 562, 576
R/tm_missing_data.R            1080    1080  0.00%    124-1380
R/tm_outliers.R                1026    1026  0.00%    162-1338
R/tm_t_crosstable.R             263     263  0.00%    177-482
R/tm_variable_browser.R         788     783  0.63%    89-1025, 1063-1246
R/utils.R                       185     120  35.14%   87-249, 278-304, 316-325, 330, 344-363, 452
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8892    8534  4.03%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  --------
R/tm_data_table.R        +1      +1  +100.00%
R/tm_g_bivariate.R       -6       0  -0.55%
TOTAL                    -5      +1  -0.07%

Results for commit: 6f74aa3

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025

Unit Tests Summary

  1 files   23 suites   24m 55s ⏱️
151 tests 140 ✅ 5 💤 0 ❌ 6 🔥
456 runs  445 ✅ 5 💤 0 ❌ 6 🔥

For more details on these errors, see this check.

Results for commit 6f74aa3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_pca 💚 $156.94$ $-2.66$ $0$ $0$ $0$ $0$
shinytest2-tm_a_regression 💚 $71.23$ $-2.39$ $0$ $0$ $0$ $0$
shinytest2-tm_data_table 💚 $29.08$ $-1.12$ $0$ $0$ $0$ $0$
shinytest2-tm_g_bivariate 💚 $91.22$ $-1.45$ $0$ $0$ $0$ $0$
shinytest2-tm_g_distribution 💚 $69.85$ $-1.18$ $0$ $0$ $0$ $0$
shinytest2-tm_g_response 💚 $38.51$ $-1.31$ $0$ $0$ $0$ $0$
shinytest2-tm_g_scatterplot 💚 $86.38$ $-2.36$ $0$ $0$ $0$ $0$
shinytest2-tm_g_scatterplotmatrix 💚 $35.51$ $-1.75$ $0$ $0$ $0$ $0$
shinytest2-tm_misssing_data 💚 $63.29$ $-1.29$ $0$ $0$ $0$ $0$
shinytest2-tm_outliers 💚 $150.16$ $-3.55$ $0$ $0$ $0$ $0$
shinytest2-tm_variable_browser 💔 $78.30$ $+541.52$ $-17$ $0$ $0$ $+6$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_variable_browser 💔 $12.01$ $+91.29$ e2e_tm_variable_browser_Selecting_treat_variable_as_factor_changes_the_table_headers.
shinytest2-tm_variable_browser 💔 $13.58$ $+89.74$ e2e_tm_variable_browser_changing_display_density_encoding_doesn_t_show_errors.
shinytest2-tm_variable_browser 💔 $15.46$ $+87.83$ e2e_tm_variable_browser_changing_outlier_definition_encoding_doesn_t_show_errors.
shinytest2-tm_variable_browser 💔 $16.63$ $+86.68$ e2e_tm_variable_browser_changing_plot_setting_encodings_doesn_t_show_errors.
shinytest2-tm_variable_browser 💔 $10.63$ $+92.72$ e2e_tm_variable_browser_content_is_displayed_correctly.
shinytest2-tm_variable_browser 💔 $10.00$ $+93.27$ e2e_tm_variable_browser_selection_of_categorical_variable_has_a_table_with_level_header.

Results for commit 1d2ee1a

♻️ This comment has been updated with latest results.

Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llrs-roche
Copy link
Contributor Author

Yes I am surprised too as it works locally, on CRAN and on the CI for v0.5.1 branch release.
But tm_variable_browser() has some issues I'm tackling in a different PR

@llrs-roche llrs-roche merged commit a3fb08d into main Oct 27, 2025
27 of 30 checks passed
@llrs-roche llrs-roche deleted the rm_ggmosaic@main branch October 27, 2025 10:23
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants