Skip to content

Conversation

@m7pr
Copy link
Contributor

@m7pr m7pr commented Oct 16, 2025

Follow-up after #931

@m7pr m7pr requested a review from llrs-roche October 16, 2025 11:03
@m7pr m7pr added the core label Oct 16, 2025
Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I would wait until the card has the default label from the module before merging

@llrs-roche llrs-roche self-assigned this Oct 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -------------------------------------------
R/tm_a_pca.R                    865     865  0.00%    141-1133
R/tm_a_regression.R             751     751  0.00%    180-1027
R/tm_data_table.R               200     200  0.00%    100-348
R/tm_file_viewer.R              172     172  0.00%    47-254
R/tm_front_page.R               143     132  7.69%    77-246
R/tm_g_association.R            320     320  0.00%    161-547
R/tm_g_bivariate.R              670     406  39.40%   332-786, 827, 938, 955, 973, 984-1006
R/tm_g_distribution.R          1106    1106  0.00%    156-1404
R/tm_g_response.R               345     345  0.00%    179-594
R/tm_g_scatterplot.R            709     709  0.00%    261-1065
R/tm_g_scatterplotmatrix.R      272     253  6.99%    200-501, 562, 576
R/tm_missing_data.R            1080    1080  0.00%    124-1380
R/tm_outliers.R                1026    1026  0.00%    162-1338
R/tm_t_crosstable.R             263     263  0.00%    177-482
R/tm_variable_browser.R         788     783  0.63%    89-1025, 1063-1246
R/utils.R                       185     120  35.14%   87-249, 278-304, 316-325, 330, 344-363, 452
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8897    8533  4.09%

Diff against main

Filename                      Stmts    Miss  Cover
--------------------------  -------  ------  --------
R/tm_a_pca.R                     -1      -1  +100.00%
R/tm_a_regression.R              -1      -1  +100.00%
R/tm_g_association.R             -1      -1  +100.00%
R/tm_g_bivariate.R               -1      -1  +0.06%
R/tm_g_distribution.R            -1      -1  +100.00%
R/tm_g_response.R                -1      -1  +100.00%
R/tm_g_scatterplot.R             -1      -1  +100.00%
R/tm_g_scatterplotmatrix.R       -1      -1  +0.03%
R/tm_missing_data.R              -1      -1  +100.00%
R/tm_outliers.R                  -1      -1  +100.00%
R/tm_t_crosstable.R              -1      -1  +100.00%
TOTAL                           -11     -11  +0.01%

Results for commit: 048f126

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025

Unit Tests Summary

  1 files  23 suites   10s ⏱️
151 tests 36 ✅ 115 💤 0 ❌
194 runs  79 ✅ 115 💤 0 ❌

Results for commit 048f126.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
examples 💚 $5.93$ $-5.34$ $-1$ $+36$ $0$ $0$
shinytest2-tm_a_pca 💚 $161.54$ $-160.43$ $-38$ $+11$ $0$ $0$
shinytest2-tm_a_regression 💚 $74.21$ $-73.53$ $-24$ $+7$ $0$ $0$
shinytest2-tm_data_table 💚 $30.16$ $-29.77$ $-6$ $+4$ $0$ $0$
shinytest2-tm_file_viewer 💚 $34.90$ $-34.16$ $-9$ $+4$ $0$ $0$
shinytest2-tm_front_page 💚 $27.81$ $-27.35$ $-6$ $+3$ $0$ $0$
shinytest2-tm_g_bivariate 💚 $96.36$ $-95.94$ $-40$ $+4$ $0$ $0$
shinytest2-tm_g_distribution 💚 $72.82$ $-72.53$ $-17$ $+3$ $0$ $0$
shinytest2-tm_g_response 💚 $40.14$ $-39.74$ $-13$ $+4$ $0$ $0$
shinytest2-tm_g_scatterplot 💚 $90.21$ $-89.66$ $-30$ $+5$ $0$ $0$
shinytest2-tm_g_scatterplotmatrix 💚 $37.84$ $-37.06$ $-5$ $+4$ $0$ $0$
shinytest2-tm_misssing_data 💚 $51.11$ $-50.08$ $-6$ $+5$ $0$ $-4$
shinytest2-tm_outliers 💚 $163.19$ $-162.15$ $-51$ $+10$ $0$ $0$
shinytest2-tm_t_crosstable 💚 $42.53$ $-41.77$ $-5$ $+4$ $0$ $0$
shinytest2-tm_variable_browser 💚 $84.78$ $-84.09$ $-17$ $+6$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
examples 💚 $2.16$ $-2.15$ example_add_facet_labels.Rd
shinytest2-tm_a_pca 💚 $13.83$ $-13.74$ e2e_tm_a_pca_Changing_output_encodings_for_plot_type_does_not_generate_errors.
shinytest2-tm_a_pca 💚 $8.26$ $-8.17$ e2e_tm_a_pca_Changing_output_encodings_of_NA_action_does_not_generate_errors.
shinytest2-tm_a_pca 💚 $32.13$ $-32.04$ e2e_tm_a_pca_Changing_output_encodings_of_font_size_does_not_generate_errors.
shinytest2-tm_a_pca 💚 $31.94$ $-31.85$ e2e_tm_a_pca_Changing_output_encodings_of_plot_type_hides_and_shows_options.
shinytest2-tm_a_pca 💚 $13.55$ $-13.47$ e2e_tm_a_pca_Changing_output_encodings_of_standardization_does_not_generate_errors.
shinytest2-tm_a_pca 💚 $8.95$ $-8.86$ e2e_tm_a_pca_Changing_output_encodings_of_tables_display_does_not_generate_errors.
shinytest2-tm_a_pca 💚 $9.92$ $-9.83$ e2e_tm_a_pca_Changing_output_encodings_of_theme_does_not_generate_errors.
shinytest2-tm_a_pca 💚 $12.64$ $-12.55$ e2e_tm_a_pca_Color_by_columns_data_extract_must_be_from_non_selected_variable_set.
shinytest2-tm_a_pca 💚 $8.81$ $-8.70$ e2e_tm_a_pca_Eigenvector_table_should_have_data_extract_selection_Murder_Assault_on_header.
shinytest2-tm_a_pca 💚 $12.21$ $-12.12$ e2e_tm_a_pca_Eigenvector_table_should_have_data_extract_selection_Murder_UrbanPop_on_header.
shinytest2-tm_a_pca 💚 $9.30$ $-9.10$ e2e_tm_a_pca_Module_is_initialised_with_the_specified_defaults_in_function_call.
shinytest2-tm_a_regression 💚 $7.23$ $-7.13$ e2e_tm_a_regression_Data_extract_spec_elements_are_initialized_with_the_default_values_specified_by_response_and_regressor_arg.
shinytest2-tm_a_regression 💚 $7.19$ $-7.09$ e2e_tm_a_regression_Data_parameter_and_module_label_is_passed_properly.
shinytest2-tm_a_regression 💚 $11.69$ $-11.61$ e2e_tm_a_regression_Outlier_definition_and_label_are_visible_by_default.
shinytest2-tm_a_regression 💚 $7.35$ $-7.26$ e2e_tm_a_regression_Outlier_definition_and_label_have_default_values_and_label_text.
shinytest2-tm_a_regression 💚 $18.46$ $-18.33$ e2e_tm_a_regression_Plot_type_has_7_specific_choices_changing_choices_does_not_throw_errors.
shinytest2-tm_a_regression 💚 $9.56$ $-9.47$ e2e_tm_a_regression_Plot_type_is_set_properly.
shinytest2-tm_a_regression 💚 $12.73$ $-12.64$ e2e_tm_a_regression_Unchecking_display_outlier_hides_outlier_label_and_definition.
shinytest2-tm_data_table 💚 $6.51$ $-6.40$ e2e_tm_data_table_Initializes_without_errors
shinytest2-tm_data_table 💚 $6.57$ $-6.47$ e2e_tm_data_table_Verify_checkbox_displayed_over_data_table
shinytest2-tm_data_table 💚 $7.50$ $-7.41$ e2e_tm_data_table_Verify_default_variable_selection_and_set_new_selection
shinytest2-tm_data_table 💚 $9.59$ $-9.49$ e2e_tm_data_table_Verify_module_displays_data_table
shinytest2-tm_file_viewer 💚 $7.00$ $-6.68$ e2e_tm_file_viewer_Initializes_without_errors_and_shows_files_tree_specified_in_input_path_argument
shinytest2-tm_file_viewer 💚 $9.08$ $-8.95$ e2e_tm_file_viewer_Shows_selected_image_file
shinytest2-tm_file_viewer 💚 $9.46$ $-9.33$ e2e_tm_file_viewer_Shows_selected_text_file
shinytest2-tm_file_viewer 💚 $9.36$ $-9.20$ e2e_tm_file_viewer_Shows_selected_url
shinytest2-tm_front_page 💚 $6.12$ $-5.96$ e2e_tm_front_page_Initializes_without_errors_and_check_html_elements
shinytest2-tm_front_page 💚 $11.20$ $-11.05$ e2e_tm_front_page_Verify_the_module_displays_metadata
shinytest2-tm_front_page 💚 $10.50$ $-10.35$ e2e_tm_front_page_Verify_the_module_displays_tables
shinytest2-tm_g_bivariate 💚 $21.81$ $-21.69$ e2e_tm_g_bivariate_Coloring_options_are_hidden_when_coloring_is_toggled_off.
shinytest2-tm_g_bivariate 💚 $26.10$ $-26.00$ e2e_tm_g_bivariate_Facetting_options_are_hidden_when_facet_is_toggled_off.
shinytest2-tm_g_bivariate 💚 $8.89$ $-8.78$ e2e_tm_g_bivariate_Module_is_initialised_with_the_specified_defaults.
shinytest2-tm_g_bivariate 💚 $39.57$ $-39.47$ e2e_tm_g_bivariate_Setting_encoding_inputs_produces_outputs_without_validation_errors.
shinytest2-tm_g_distribution 💚 $23.13$ $-23.02$ e2e_tm_g_distribution_Histogram_encoding_inputs_produce_output_without_validation_errors.
shinytest2-tm_g_distribution 💚 $36.29$ $-36.19$ e2e_tm_g_distribution_Module_is_initialised_with_the_specified_defaults.
shinytest2-tm_g_distribution 💚 $13.41$ $-13.32$ e2e_tm_g_distribution_QQ_plot_encoding_inputs_produce_output_without_validation_errors.
shinytest2-tm_g_response 💚 $7.91$ $-7.81$ e2e_tm_g_response_deselecting_response_produces_validation_error.
shinytest2-tm_g_response 💚 $7.96$ $-7.86$ e2e_tm_g_response_deselecting_x_produces_validation_error.
shinytest2-tm_g_response 💚 $16.41$ $-16.30$ e2e_tm_g_response_encoding_inputs_produce_output_without_validation_errors.
shinytest2-tm_g_response 💚 $7.87$ $-7.77$ e2e_tm_g_response_module_is_initialised_with_the_specified_defaults.
shinytest2-tm_g_scatterplot 💚 $11.97$ $-11.85$ e2e_tm_g_scatterplot_Base_for_the_log_transformation_can_be_applied.
shinytest2-tm_g_scatterplot 💚 $10.02$ $-9.91$ e2e_tm_g_scatterplot_Get_validation_error_when_facetting_with_the_same_row_col_variable.
shinytest2-tm_g_scatterplot 💚 $8.02$ $-7.91$ e2e_tm_g_scatterplot_Module_is_initialised_with_the_specified_defaults.
shinytest2-tm_g_scatterplot 💚 $47.98$ $-47.87$ e2e_tm_g_scatterplot_The_encoding_inputs_are_set_without_validation_errors.
shinytest2-tm_g_scatterplot 💚 $12.22$ $-12.12$ e2e_tm_g_scatterplot_The_log_transform_is_only_possible_for_positive_numeric_vars.
shinytest2-tm_g_scatterplotmatrix 💚 $11.65$ $-11.51$ e2e_tm_g_scatterplotmatrix_Change_plot_settings
shinytest2-tm_g_scatterplotmatrix 💚 $7.44$ $-7.27$ e2e_tm_g_scatterplotmatrix_Initializes_without_errors
shinytest2-tm_g_scatterplotmatrix 💚 $9.10$ $-8.93$ e2e_tm_g_scatterplotmatrix_Verify_default_values_and_settings_data_extracts_for_data_selection
shinytest2-tm_g_scatterplotmatrix 💚 $9.65$ $-9.35$ e2e_tm_g_scatterplotmatrix_Verify_module_displays_data_table
shinytest2-tm_misssing_data 💚 $16.56$ $-16.35$ e2e_tm_missing_data_Check_default_settings_and_visibility_of_the_combinations_graph_and_encodings
shinytest2-tm_misssing_data 💚 $8.64$ $-8.43$ e2e_tm_missing_data_Default_settings_and_visibility_of_the_summary_graph
shinytest2-tm_misssing_data 💚 $8.53$ $-8.32$ e2e_tm_missing_data_Initializes_without_errors
shinytest2-tm_misssing_data 💚 $8.73$ $-8.53$ e2e_tm_missing_data_Validate_By_Variable_Levels_table_values
shinytest2-tm_misssing_data 💚 $8.65$ $-8.45$ e2e_tm_missing_data_Validate_functionality_and_UI_response_for_By_Variable_Levels_
shinytest2-tm_outliers 💚 $15.86$ $-15.74$ e2e_tm_outliers_Data_extract_spec_elements_are_initialized_with_the_default_values_specified_by_outlier_var_and_categorical_var_argument.
shinytest2-tm_outliers 💚 $10.08$ $-9.97$ e2e_tm_outliers_Data_parameter_and_module_label_is_passed_properly.
shinytest2-tm_outliers 💚 $15.43$ $-15.32$ e2e_tm_outliers_Default_radio_buttons_are_set_properly.
shinytest2-tm_outliers 💚 $10.19$ $-10.09$ e2e_tm_outliers_Method_parameters_are_set_properly.
shinytest2-tm_outliers 💚 $10.16$ $-10.06$ e2e_tm_outliers_Module_is_divided_into_3_tabs.
shinytest2-tm_outliers 💚 $33.34$ $-33.23$ e2e_tm_outliers_Outlier_definition_text_and_range_are_displayed_properly_depending_on_method.
shinytest2-tm_outliers 💚 $15.19$ $-15.09$ e2e_tm_outliers_Outlier_table_is_displayed_with_proper_content.
shinytest2-tm_outliers 💚 $17.44$ $-17.34$ e2e_tm_outliers_Outliers_summary_table_is_displayed_with_proper_content.
shinytest2-tm_outliers 💚 $12.86$ $-12.75$ e2e_tm_outliers_Plot_type_is_correctly_set_by_default_and_has_appropriate_possible_options.
shinytest2-tm_outliers 💚 $22.65$ $-22.55$ e2e_tm_outliers_Plot_type_is_hidden_when_Boxplot_tab_is_not_selected.
shinytest2-tm_t_crosstable 💚 $13.31$ $-13.18$ e2e_tm_t_crosstable_Change_plot_settings
shinytest2-tm_t_crosstable 💚 $8.15$ $-7.78$ e2e_tm_t_crosstable_Initializes_without_errors
shinytest2-tm_t_crosstable 💚 $10.88$ $-10.75$ e2e_tm_t_crosstable_Verify_default_values_and_settings_data_extracts_for_data_selection
shinytest2-tm_t_crosstable 💚 $10.19$ $-10.05$ e2e_tm_t_crosstable_Verify_module_displays_data_table
shinytest2-tm_variable_browser 💚 $13.04$ $-12.93$ e2e_tm_variable_browser_Selecting_treat_variable_as_factor_changes_the_table_headers.
shinytest2-tm_variable_browser 💚 $14.40$ $-14.29$ e2e_tm_variable_browser_changing_display_density_encoding_doesn_t_show_errors.
shinytest2-tm_variable_browser 💚 $16.50$ $-16.38$ e2e_tm_variable_browser_changing_outlier_definition_encoding_doesn_t_show_errors.
shinytest2-tm_variable_browser 💚 $17.91$ $-17.80$ e2e_tm_variable_browser_changing_plot_setting_encodings_doesn_t_show_errors.
shinytest2-tm_variable_browser 💚 $11.75$ $-11.63$ e2e_tm_variable_browser_content_is_displayed_correctly.
shinytest2-tm_variable_browser 💚 $11.18$ $-11.07$ e2e_tm_variable_browser_selection_of_categorical_variable_has_a_table_with_level_header.

Results for commit 16354b6

♻️ This comment has been updated with latest results.

@m7pr m7pr enabled auto-merge (squash) October 17, 2025 11:05
@m7pr m7pr merged commit c5e007b into main Oct 17, 2025
22 of 24 checks passed
@m7pr m7pr deleted the 400_followup branch October 17, 2025 11:16
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants