Do we need all datasets in SRC output of waterfall module?

[cicdguy]

@npaszty
please see sample app SRC output

NEST/teal.osprey/blob/master/R/tm_g_waterfall.R#L140). I think it can be improved to limit only those of interest in encoding panel.

The issue existed in the December release thus moving it to the main backlog

Provenance:

Creator: pawelru

[cicdguy]

@pawelru
not that familiar with osprey design/architecture.
if there are ways to improve that then I wouldn't think anyone would oppose.
all 9 data sets are present in the filter panel on the waterfall tab & patient profile. whereas other tabs have only the relevant data sets. so looks like similar approach could be taken to minimize unnecessary objects.

Provenance:

Creator: npaszty

[cicdguy]

not that familiar with osprey design/architecture.

Is there anyone to ask for confirmation here?

Provenance:

Creator: pawelru

[cicdguy]

is confirmation needed?
isn't it just a case of not wanting to bloat the app and SRC if objects not needed?
I believe Jana was one of the osprey developers

Provenance:

Creator: npaszty

[cicdguy]

yes you are right - let's just simply do it

Provenance:

Creator: pawelru