fix: only add title to blocks if title exists

averissimo · averissimo · commit 7bb10801cac6 · 2025-06-02T12:52:28.000+01:00
diff --git a/R/Reporter.R b/R/Reporter.R
@@ -212,7 +212,12 @@ Reporter <- R6::R6Class( # nolint: object_name_linter.
           if (idx != length(cards)) blocks <- append(blocks, sep)
           next # Easier to remove when ReportCard is fully deprecated
         }
-        card_with_title <- c(report_document(sprintf("# %s", metadata(card, "title"))), card)
+        card_with_title <- if (length(metadata(card, "title")) > 0) {
+          c(report_document(sprintf("# %s", metadata(card, "title"))), card)
+        } else {
+          card
+        }
+
         blocks <- append(blocks, unclass(card_with_title))
         if (idx != length(cards)) blocks <- append(blocks, trimws(sep))
       }

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,12 @@ Reporter <- R6::R6Class( # nolint: object_name_linter.`
`212`	`212`	`if (idx != length(cards)) blocks <- append(blocks, sep)`
`213`	`213`	`next # Easier to remove when ReportCard is fully deprecated`
`214`	`214`	`}`
`215`		`- card_with_title <- c(report_document(sprintf("# %s", metadata(card, "title"))), card)`
	`215`	`+ card_with_title <- if (length(metadata(card, "title")) > 0) {`
	`216`	`+ c(report_document(sprintf("# %s", metadata(card, "title"))), card)`
	`217`	`+ } else {`
	`218`	`+ card`
	`219`	`+ }`
	`220`	`+`
`216`	`221`	`blocks <- append(blocks, unclass(card_with_title))`
`217`	`222`	`if (idx != length(cards)) blocks <- append(blocks, trimws(sep))`
`218`	`223`	`}`