Skip to content

Commit 2ebbcb0

Browse files
authored
Switch to bslib (#259)
Closes #250
1 parent eebceec commit 2ebbcb0

22 files changed

+78
-105
lines changed

DESCRIPTION

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ Depends:
2323
Imports:
2424
checkmate (>= 2.1.0),
2525
dplyr (>= 1.1.0),
26+
htmltools,
2627
lifecycle (>= 0.2.0),
2728
logger (>= 0.2.0),
2829
methods,
@@ -38,6 +39,7 @@ Imports:
3839
tidyselect,
3940
utils
4041
Suggests:
42+
bslib (>= 0.8.0),
4143
knitr (>= 1.42),
4244
rmarkdown (>= 2.23),
4345
roxy.shinylive (>= 1.0.0),

R/choices_labeled.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
#' subset = c("ARMCD", "ARM")
4040
#' )
4141
#'
42-
#' ui <- fluidPage(
42+
#' ui <- bslib::page_fluid(
4343
#' selectInput("c1",
4444
#' label = "Choices from ADSL",
4545
#' choices = choices1,

R/choices_selected.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ no_select_keyword <- "-- no selection --"
116116
#' selected = "A"
117117
#' )
118118
#'
119-
#' ui <- fluidPage(
119+
#' ui <- bslib::page_fluid(
120120
#' optionalSelectInput(
121121
#' inputId = "id",
122122
#' choices = cs$choices,

R/data_extract_module.R

Lines changed: 27 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,18 @@ cond_data_extract_single_ui <- function(ns, single_data_extract_spec) {
4747
)
4848
}
4949

50+
#' @keywords internal
51+
#' @noRd
52+
data_extract_deps <- function() {
53+
htmltools::htmlDependency(
54+
name = "teal-widgets-data-extract",
55+
version = utils::packageVersion("teal.transform"),
56+
package = "teal.transform",
57+
src = "css",
58+
stylesheet = "data-extract.css"
59+
)
60+
}
61+
5062
#' `teal` data extraction module user-interface
5163
#'
5264
#' @description
@@ -109,9 +121,9 @@ cond_data_extract_single_ui <- function(ns, single_data_extract_spec) {
109121
#' )
110122
#' )
111123
#' # Call to use inside your teal module UI function
112-
#' standard_layout(
113-
#' output = tableOutput("table"),
114-
#' encoding = tags$div(
124+
#' bslib::layout_sidebar(
125+
#' tableOutput("table"),
126+
#' sidebar = tags$div(
115127
#' data_extract_ui(
116128
#' id = "regressor",
117129
#' label = "Regressor Variable",
@@ -170,7 +182,7 @@ data_extract_ui <- function(id, label, data_extract_spec, is_single_dataset = FA
170182
}
171183
}
172184
tagList(
173-
include_css_files(pattern = "data_extract"),
185+
data_extract_deps(),
174186
tags$div(
175187
class = "data-extract",
176188
tags$label(label),
@@ -322,9 +334,9 @@ check_data_extract_spec_react <- function(datasets, data_extract) {
322334
#' join_keys <- join_keys(join_key("ADSL", "ADSL", c("STUDYID", "USUBJID")))
323335
#'
324336
#' # App: data extraction with validation
325-
#' ui <- fluidPage(
326-
#' standard_layout(
327-
#' output = verbatimTextOutput("out1"),
337+
#' ui <- bslib::page_fluid(
338+
#' bslib::layout_sidebar(
339+
#' verbatimTextOutput("out1"),
328340
#' encoding = tagList(
329341
#' data_extract_ui(
330342
#' id = "adsl_var",
@@ -364,10 +376,10 @@ check_data_extract_spec_react <- function(datasets, data_extract) {
364376
#' }
365377
#'
366378
#' # App: simplified data extraction
367-
#' ui <- fluidPage(
368-
#' standard_layout(
369-
#' output = verbatimTextOutput("out1"),
370-
#' encoding = tagList(
379+
#' ui <- bslib::page_fluid(
380+
#' bslib::layout_sidebar(
381+
#' verbatimTextOutput("out1"),
382+
#' sidebar = tagList(
371383
#' data_extract_ui(
372384
#' id = "adsl_var",
373385
#' label = "ADSL selection",
@@ -613,11 +625,11 @@ data_extract_srv.list <- function(id,
613625
#'
614626
#' data_list <- list(iris = reactive(iris))
615627
#'
616-
#' ui <- fluidPage(
628+
#' ui <- bslib::page_fluid(
617629
#' useShinyjs(),
618-
#' standard_layout(
619-
#' output = verbatimTextOutput("out1"),
620-
#' encoding = tagList(
630+
#' bslib::layout_sidebar(
631+
#' verbatimTextOutput("out1"),
632+
#' sidebar = tagList(
621633
#' data_extract_ui(
622634
#' id = "x_var",
623635
#' label = "Please select an X column",

R/format_data_extract.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
#' select = select_spec(choices = c("Petal.Length", "Species"))
1919
#' )
2020
#'
21-
#' ui <- fluidPage(
21+
#' ui <- bslib::page_fluid(
2222
#' data_extract_ui(
2323
#' id = "extract",
2424
#' label = "data extract ui",

R/include_css_js.R

Lines changed: 0 additions & 20 deletions
This file was deleted.

R/merge_expression_module.R

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -80,13 +80,13 @@
8080
#' )
8181
#' )
8282
#'
83-
#' ui <- fluidPage(
84-
#' standard_layout(
85-
#' output = tags$div(
83+
#' ui <- bslib::page_fluid(
84+
#' bslib::layout_sidebar(
85+
#' tags$div(
8686
#' verbatimTextOutput("expr"),
8787
#' dataTableOutput("data")
8888
#' ),
89-
#' encoding = tagList(
89+
#' sidebar = tagList(
9090
#' data_extract_ui("adsl_var", label = "ADSL selection", adsl_extract),
9191
#' data_extract_ui("adlb_var", label = "ADLB selection", adlb_extract)
9292
#' )
@@ -278,13 +278,13 @@ merge_expression_module.list <- function(datasets,
278278
#' )
279279
#' )
280280
#'
281-
#' ui <- fluidPage(
282-
#' standard_layout(
283-
#' output = tags$div(
281+
#' ui <- bslib::page_fluid(
282+
#' bslib::layout_sidebar(
283+
#' tags$div(
284284
#' verbatimTextOutput("expr"),
285285
#' dataTableOutput("data")
286286
#' ),
287-
#' encoding = tagList(
287+
#' sidebar = tagList(
288288
#' data_extract_ui("adsl_var", label = "ADSL selection", adsl_extract),
289289
#' data_extract_ui("adlb_var", label = "ADLB selection", adlb_extract)
290290
#' )

R/utils.R

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,11 @@ extract_choices_labels <- function(choices, values = NULL) {
8282
#'
8383
#' data_list <- list(iris = reactive(iris))
8484
#'
85-
#' ui <- fluidPage(
85+
#' ui <- bslib::page_fluid(
8686
#' useShinyjs(),
87-
#' standard_layout(
88-
#' output = verbatimTextOutput("out1"),
89-
#' encoding = tagList(
87+
#' bslib::layout_sidebar(
88+
#' verbatimTextOutput("out1"),
89+
#' sidebar = tagList(
9090
#' data_extract_ui(
9191
#' id = "x_var",
9292
#' label = "Please select an X column",

inst/css/data_extract.css renamed to inst/css/data-extract.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/* teal.transform data_extract css */
22

33
.data-extract {
4-
border-left: 3px solid #e3e3e3;
4+
border-left: 3px solid var(--bs-gray-200);
55
padding-left: 0.6em;
66
border-radius: 5px;
77
margin-left: -0.6em;

man/choices_labeled.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)