Vbump rtables to get BS5 fix + increase timeout to pass integration tests (#316)

## Changes

### 1. vbump `rtables`
The `rtables::build_table` causes error when using `rtables` version
older than `0.6.8`. However, I'm bumping it further to `0.6.12` because
it has a BS5 related
[fix](insightsengineering/rtables#1014).
I will retrigger the integration tests once this is merged.

```r
df1 <- data.frame(
  AGE = c(35, 41),
  SEX = factor(c("M", "F")),
  ARM = c("B: Placebo", "C: Combination")
)
l1 <- rtables::basic_table()
l2 <- rtables::split_cols_by(l1, "ARM")
l3 <- rtables::analyze(l2, c("SEX", "AGE"))
tbl <- rtables::build_table(l3, df1)
tbl
```

### 2. Increase timeout
To reproduce the integration test failure please remove the
`app_driver$wait_for_idle(timeout = longer_timeout)` and run the tests
to see some inconsistency. I suspect that increasing the timeout would
help us pass tests more consistently.


### 3. Remove test for deprecated function
`nested_closeable_modal` is deprecated and will be removed in a future
release. We do not plan to update this function before that happens, So,
the test is redundant now, we already know it works. This is just
increasing the testing time and nothing else.

Author: vedhav

DESCRIPTION

@@ -30,7 +30,7 @@ Imports:
     htmltools (>= 0.5.4),
     lifecycle (>= 0.2.0),
     methods,
-    rtables (>= 0.6.6),
+    rtables (>= 0.6.12),
     shiny (>= 1.8.1),
     shinyjs (>= 2.1.0),
     shinyWidgets (>= 0.5.1),

tests/testthat/test-nested_closeable_modal_ui.R

@@ -30,6 +30,8 @@ app_driver_tws <- function() {
   )
 }
 
+longer_timeout <- 80000
+
 # nolint start
 # JS code to click the expand button popup.
 click_expand_popup <- "document.querySelector('#table_with_settings-table-with-settings > bslib-tooltip > button').click()"
@@ -72,7 +74,7 @@ testthat::test_that(
       name = "tws",
       variant = "app_driver_tws_ui",
     )
-    app_driver$wait_for_idle(timeout = default_idle_timeout)
+    app_driver$wait_for_idle(timeout = longer_timeout)
 
     # Check if there is an table.
     testthat::expect_true(is_visible("#table_with_settings-table_out_main .rtables-container", app_driver))
@@ -94,14 +96,14 @@ testthat::test_that(
       name = "tws",
       variant = "app_driver_tws_ui",
     )
-    app_driver$wait_for_idle(timeout = default_idle_timeout)
+    app_driver$wait_for_idle(timeout = longer_timeout)
 
     testthat::expect_false(is_visible("#table_with_settings-downbutton-data_download", app_driver))
     testthat::expect_false(is_visible("#table_with_settings-downbutton-file_format", app_driver))
     testthat::expect_false(is_visible("#table_with_settings-downbutton-file_name", app_driver))
 
     app_driver$run_js(click_download_popup)
-    app_driver$wait_for_idle(timeout = default_idle_timeout)
+    app_driver$wait_for_idle(timeout = longer_timeout)
 
     testthat::expect_equal(
       app_driver$get_text("#table_with_settings-downbutton-file_format-label"),
@@ -158,17 +160,17 @@ testthat::test_that(
       name = "tws",
       variant = "app_driver_tws_ui",
     )
-    app_driver$wait_for_idle(timeout = default_idle_timeout)
+    app_driver$wait_for_idle(timeout = longer_timeout)
 
     app_driver$run_js(click_download_popup)
-    app_driver$wait_for_idle(timeout = default_idle_timeout)
+    app_driver$wait_for_idle(timeout = longer_timeout)
 
     pagination_text <- app_driver$get_text(".paginate-ui")
     testthat::expect_match(pagination_text, "Paginate table:\n", fixed = TRUE)
     testthat::expect_match(pagination_text, "lines / page\n", fixed = TRUE)
 
     app_driver$click(selector = "input[value='.csv']")
-    app_driver$wait_for_idle(timeout = default_idle_timeout)
+    app_driver$wait_for_idle(timeout = longer_timeout)
 
     testthat::expect_false(is_visible(".paginate-ui", app_driver))
 
@@ -185,13 +187,13 @@ testthat::test_that(
       name = "tws",
       variant = "app_driver_tws_ui",
     )
-    app_driver$wait_for_idle(timeout = default_idle_timeout)
+    app_driver$wait_for_idle(timeout = longer_timeout)
 
     testthat::expect_false(is_visible("#table_with_settings-table_out_main", app_driver))
     testthat::expect_false(is_visible("#bslib-full-screen-overlay", app_driver))
 
     app_driver$run_js(click_expand_popup)
-    app_driver$wait_for_idle(timeout = default_idle_timeout)
+    app_driver$wait_for_idle(timeout = longer_timeout)
 
     table_content <- app_driver$get_text("#table_with_settings-table_out_main")
 
@@ -200,7 +202,7 @@ testthat::test_that(
     testthat::expect_true(is_visible("#bslib-full-screen-overlay", app_driver))
     # Close modal.
     app_driver$run_js("document.querySelector('#bslib-full-screen-overlay .bslib-full-screen-exit').click();")
-    app_driver$wait_for_idle(timeout = default_idle_timeout)
+    app_driver$wait_for_idle(timeout = longer_timeout)
     testthat::expect_false(is_visible("#bslib-full-screen-overlay", app_driver))
 
     # Review the main table content.
@@ -221,12 +223,12 @@ testthat::test_that(
       name = "tws",
       variant = "app_driver_tws_ui",
     )
-    app_driver$wait_for_idle(timeout = default_idle_timeout)
+    app_driver$wait_for_idle(timeout = longer_timeout)
 
     app_driver$run_js(click_expand_popup)
-    app_driver$wait_for_idle(timeout = default_idle_timeout)
+    app_driver$wait_for_idle(timeout = longer_timeout)
     app_driver$run_js(click_download_popup)
-    app_driver$wait_for_idle(timeout = default_idle_timeout)
+    app_driver$wait_for_idle(timeout = longer_timeout)
 
     testthat::expect_equal(
       app_driver$get_text("#table_with_settings-downbutton-file_format-label"),
@@ -287,12 +289,12 @@ testthat::test_that(
       name = "tws",
       variant = "app_driver_tws_ui",
     )
-    app_driver$wait_for_idle(timeout = default_idle_timeout)
+    app_driver$wait_for_idle(timeout = longer_timeout)
 
     app_driver$run_js(click_expand_popup)
-    app_driver$wait_for_idle(timeout = default_idle_timeout)
+    app_driver$wait_for_idle(timeout = longer_timeout)
     app_driver$run_js(click_download_popup)
-    app_driver$wait_for_idle(timeout = default_idle_timeout)
+    app_driver$wait_for_idle(timeout = longer_timeout)
 
     pagination_text <- app_driver$get_text(".paginate-ui")
     testthat::expect_match(pagination_text, "Paginate table:\n", fixed = TRUE)
@@ -311,10 +313,10 @@ testthat::test_that(
       name = "tws",
       variant = "app_driver_tws_ui",
     )
-    app_driver$wait_for_idle(timeout = default_idle_timeout)
+    app_driver$wait_for_idle(timeout = longer_timeout)
 
     app_driver$run_js(click_download_popup)
-    app_driver$wait_for_idle(timeout = default_idle_timeout)
+    app_driver$wait_for_idle(timeout = longer_timeout)
 
     filename <- app_driver$get_download("table_with_settings-downbutton-data_download")
     testthat::expect_match(filename, "txt$", fixed = FALSE)
@@ -334,13 +336,13 @@ testthat::test_that("e2e teal.widgets::table_with_settings: expanded table can b
     name = "tws",
     variant = "app_driver_tws_ui",
   )
-  app_driver$wait_for_idle(timeout = default_idle_timeout)
+  app_driver$wait_for_idle(timeout = longer_timeout)
 
   app_driver$run_js(click_expand_popup)
-  app_driver$wait_for_idle(timeout = default_idle_timeout)
+  app_driver$wait_for_idle(timeout = longer_timeout)
 
   app_driver$run_js(click_download_popup)
-  app_driver$wait_for_idle(timeout = default_idle_timeout)
+  app_driver$wait_for_idle(timeout = longer_timeout)
 
   filename <- app_driver$get_download("table_with_settings-downbutton-data_download")
   testthat::expect_match(filename, "txt$", fixed = FALSE)