Skip to content

Follow-up changes to TealAppDriver #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m7pr wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Follow-up changes to TealAppDriver #1653

Changes from 9 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
133d6f7
module_bookmark_manager tests
m7pr Nov 6, 2025
8cc34bb
Merge branch 'main' of https://github.com/insightsengineering/teal
m7pr Nov 14, 2025
7221be2
Merge branch 'main' of https://github.com/insightsengineering/teal
m7pr Nov 17, 2025
b328fac
Merge branch 'main' of https://github.com/insightsengineering/teal
m7pr Nov 19, 2025
4627fc7
Merge branch 'main' of https://github.com/insightsengineering/teal
m7pr Nov 21, 2025
ea0d6ef
Merge branch 'main' of https://github.com/insightsengineering/teal
m7pr Nov 24, 2025
c7c960e
bring tests
m7pr Nov 24, 2025
a32a9d9
Delete tests/testthat/test-module_bookmark_manager.R
m7pr Nov 24, 2025
2f6ffdf
revert 2 changes
m7pr Nov 24, 2025
f8ea37e
unsure if all this is needed
m7pr Nov 25, 2025
001ae6f
[skip style] [skip vbump] Restyle files
github-actions[bot] Nov 25, 2025
7a2a004
simplify logic, based on feedback
m7pr Nov 27, 2025
8a5d57b
Fix lintr issue
llrs-roche Dec 2, 2025
8aad92f
Logic simplification
llrs-roche Dec 2, 2025
7aaa547
[skip style] [skip vbump] Restyle files
github-actions[bot] Dec 2, 2025
a20a471
Apply suggestions from code review
llrs-roche Dec 2, 2025
6e662e8
Simplify the logic of the function
llrs-roche Dec 3, 2025
9f231ca
[skip style] [skip vbump] Restyle files
github-actions[bot] Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/TealAppDriver.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ TealAppDriver <- R6::R6Class( # nolint: object_name.
get_active_module_plot_output = function(plot_id) {
checkmate::check_string(plot_id)
self$get_attr(
self$namespaces()$module(sprintf("%s-plot_main > img", plot_id)),
self$namespaces(TRUE)$module(sprintf("%s-plot_main > img", plot_id)),
"src"
)
},
Expand Down
Loading