Follow-up changes to TealAppDriver

R/TealAppDriver.R

@@ -87,8 +87,8 @@
       )
       # end od check
 
-      private$set_active_ns()
       self$wait_for_idle()
+      private$set_active_ns()
     },
     #' @description
     #' Append parent [`shinytest2::AppDriver`] `click` method with a call to `waif_for_idle()` method.
@@ -234,7 +234,7 @@
     get_active_module_plot_output = function(plot_id) {
       checkmate::check_string(plot_id)
       self$get_attr(
-        self$namespaces()$module(sprintf("%s-plot_main > img", plot_id)),
+        self$namespaces(TRUE)$module(sprintf("%s-plot_main > img", plot_id)),
         "src"
       )
     },
@@ -249,7 +249,6 @@
     #' @return The `TealAppDriver` object invisibly.
     set_active_module_input = function(input_id, value, ...) {
       checkmate::check_string(input_id)
-      checkmate::check_string(value)
       self$set_input(
         self$namespaces()$module(input_id),
         value,
@@ -554,18 +553,76 @@
       filter_panel = character(0)
     ),
     # private methods ----
+    # Helper function to extract wrapper ID from selector and take first match if multiple found
+    extract_wrapper_id = function(selector) {
+      wrapper_id <- sub(
+        "^#",
+        "",
+        self$get_attr(selector = selector, attribute = "href")
+      )
+      # Take first match if multiple found
+      if (length(wrapper_id) > 1) {
+        wrapper_id <- wrapper_id[1]
+      }
+      wrapper_id
+    },
+    # Helper function to check if wrapper ID is valid
+    is_valid_wrapper_id = function(wrapper_id) {
+      !is.null(wrapper_id) &&
+        length(wrapper_id) > 0 &&
+        !(length(wrapper_id) == 1 && (wrapper_id == "" || is.na(wrapper_id)))
+    },
     set_active_ns = function() {
+      # Although wait_for_idle() is called before set_active_ns(), it only ensures Shiny is not processing.
+      # wait_for_page_stability() is needed here to ensure the DOM/UI is fully rendered and stable
+      # before trying to extract the namespace.
+      private$wait_for_page_stability()
+
       all_inputs <- self$get_values()$input
       active_tab_inputs <- all_inputs[grepl("-active_module_id$", names(all_inputs))]
 
-      active_wrapper_id <- sub(
-        "^#",
-        "",
-        self$get_attr(
-          selector = sprintf(".teal-modules-tree li a.module-button[data-value='%s']", active_tab_inputs),
-          attribute = "href"
+      # If no active_module_id input found, find the selected/active tab button directly
+      if (length(active_tab_inputs) == 0 || is.null(active_tab_inputs) || active_tab_inputs == "") {
+        active_wrapper_id <- private$extract_wrapper_id(
+          ".teal-modules-tree li a.module-button.active, .teal-modules-tree li a.module-button[aria-selected='true']"
         )
-      )
+        # If still not found, try any module button with a wrapper href
+        if (!private$is_valid_wrapper_id(active_wrapper_id)) {
+          active_wrapper_id <- private$extract_wrapper_id(
+            ".teal-modules-tree li a.module-button[href*='-wrapper']:not([href='#'])"
+          )
+        }
+      } else {
+        active_wrapper_id <- private$extract_wrapper_id(
+          sprintf(".teal-modules-tree li a.module-button[data-value='%s']", active_tab_inputs)
+        )
+      }
+
+      # Ensure we have a valid wrapper ID
+      # get_attr returns character(0) when no elements found, or NA_character_ for missing attributes
+      if (!private$is_valid_wrapper_id(active_wrapper_id)) {
+        # Try one more time after a short wait - the page might still be loading
+        Sys.sleep(0.5)
+        active_wrapper_id <- private$extract_wrapper_id(
+          ".teal-modules-tree li a.module-button[href*='-wrapper']:not([href='#'])"
+        )
+      }
+
+      # Final check - if still not found, throw error with diagnostic information
+      if (!private$is_valid_wrapper_id(active_wrapper_id)) {
+        found_ids <- paste(
+          self$get_attr(
+            selector = ".teal-modules-tree li a.module-button[href*='-wrapper']",
+            attribute = "href"
+          ),
+          collapse = ", "
+        )
+        stop(sprintf(
+          "Could not determine active module namespace. Make sure a module tab is selected and the page has finished loading. Found wrapper IDs: %s",
+          if (length(found_ids) > 0) found_ids else "none"
+        ))
+      }
+
       active_base_id <- sub("-wrapper$", "", active_wrapper_id)
 
       private$ns$base_id <- active_base_id