From a8cefb3b0fb3749a6dd62cf8be11af4258723437 Mon Sep 17 00:00:00 2001 From: Joe Zhu Date: Mon, 10 Mar 2025 13:09:42 +0800 Subject: [PATCH] upversion r min version, and survial depednecies --- DESCRIPTION | 4 ++-- tests/testthat/_snaps/coxph.md | 2 +- tests/testthat/test-coxph.R | 4 ---- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 1d00535bbb..263929e6f4 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -24,7 +24,7 @@ URL: https://insightsengineering.github.io/tern/, https://github.com/insightsengineering/tern/ BugReports: https://github.com/insightsengineering/tern/issues Depends: - R (>= 3.6), + R (>= 4.4.0), rtables (>= 0.6.11) Imports: broom (>= 0.5.4), @@ -49,7 +49,7 @@ Imports: rlang (>= 1.1.0), scales (>= 1.2.0), stats, - survival (>= 3.6-4), + survival (>= 3.8-3), tibble (>= 2.0.0), tidyr (>= 0.8.3), utils diff --git a/tests/testthat/_snaps/coxph.md b/tests/testthat/_snaps/coxph.md index c5377d140e..aecfdf90a5 100644 --- a/tests/testthat/_snaps/coxph.md +++ b/tests/testthat/_snaps/coxph.md @@ -50,7 +50,7 @@ Code res Output - [1] 1.0000000 1.0000000 0.9678110 0.3970066 0.3252267 0.5286392 + [1] 1.0000000 0.7521316 0.3858022 --- diff --git a/tests/testthat/test-coxph.R b/tests/testthat/test-coxph.R index 2020c159a1..73c8739620 100644 --- a/tests/testthat/test-coxph.R +++ b/tests/testthat/test-coxph.R @@ -45,10 +45,6 @@ testthat::test_that("estimate_coef works correctly", { }) testthat::test_that("try_car_anova works correctly", { - testthat::skip_if(packageVersion("survival") >= "3.8-3", - message = "Skip test is version is greater than 3.8-3, breaking change" - ) - mod <- survival::coxph( formula = survival::Surv(time = futime, event = fustat) ~ factor(rx) + survival::strata(ecog.ps), data = survival::ovarian