[Fix] in node 0.8, TAs do not coerce Uint8Arrays to an ArrayBuffer properly

Author: ljharb

index.js

@@ -3,6 +3,7 @@
 var callBind = require('call-bind');
 var callBound = require('call-bind/callBound');
 var GetIntrinsic = require('get-intrinsic');
+var isTypedArray = require('is-typed-array');
 
 var $ArrayBuffer = GetIntrinsic('ArrayBuffer', true);
 var $Float32Array = GetIntrinsic('Float32Array', true);
@@ -32,7 +33,7 @@ module.exports = $byteLength || $abSlice
 		// in node 0.8, ArrayBuffers have no prototype or own methods
 		? function IsArrayBuffer(obj) {
 			try {
-				return (new $Float32Array(obj)).buffer === obj;
+				return (new $Float32Array(obj)).buffer === obj && !isTypedArray(obj);
 			} catch (e) {
 				return false;
 			}

package.json

@@ -45,6 +45,7 @@
 		"@ljharb/eslint-config": "^21.0.1",
 		"aud": "^2.0.2",
 		"auto-changelog": "^2.4.0",
+		"available-typed-arrays": "^1.0.5",
 		"es-value-fixtures": "^1.4.2",
 		"eslint": "=8.8.0",
 		"for-each": "^0.3.3",
@@ -66,7 +67,8 @@
 	},
 	"dependencies": {
 		"call-bind": "^1.0.2",
-		"get-intrinsic": "^1.1.3"
+		"get-intrinsic": "^1.1.3",
+		"is-typed-array": "^1.1.10"
 	},
 	"publishConfig": {
 		"ignore": [

test/index.js

@@ -4,6 +4,7 @@ var test = require('tape');
 var inspect = require('object-inspect');
 var forEach = require('for-each');
 var v = require('es-value-fixtures');
+var availableTypedArrays = require('available-typed-arrays')();
 
 var isArrayBuffer = require('..');
 
@@ -26,5 +27,15 @@ test('isArrayBuffer', function (t) {
 		st.end();
 	});
 
+	t.test('Typed Arrays', { skip: availableTypedArrays.length === 0 }, function (st) {
+		forEach(availableTypedArrays, function (TypedArray) {
+			var ta = new global[TypedArray](0);
+			st.equal(isArrayBuffer(ta.buffer), true, inspect(ta.buffer) + ', the TA\'s buffer, is an ArrayBuffer');
+			st.equal(isArrayBuffer(ta), false, inspect(ta) + ' is not an ArrayBuffer');
+		});
+
+		st.end();
+	});
+
 	t.end();
 });