[Refactor] explicitly coerce Error objects to strings.

ljharb · ljharb · commit 7f4ca8424ee8 · 2017-01-28T09:42:13.000-08:00
This ensures that `toString` is called over `valueOf`.
diff --git a/index.js b/index.js
@@ -75,8 +75,8 @@ module.exports = function inspect_ (obj, opts, depth, seen) {
                 parts.push(key + ': ' + inspect(obj[key]));
             }
         }
-        if (parts.length === 0) return '[' + obj + ']';
-        return '{ [' + obj + '] ' + parts.join(', ') + ' }';
+        if (parts.length === 0) return '[' + String(obj) + ']';
+        return '{ [' + String(obj) + '] ' + parts.join(', ') + ' }';
     }
     else if (typeof obj === 'object' && typeof obj.inspect === 'function') {
         return obj.inspect();

Original file line number	Diff line number	Diff line change
`@@ -75,8 +75,8 @@ module.exports = function inspect_ (obj, opts, depth, seen) {`
`75`	`75`	`parts.push(key + ': ' + inspect(obj[key]));`
`76`	`76`	`}`
`77`	`77`	`}`
`78`		`- if (parts.length === 0) return '[' + obj + ']';`
`79`		`- return '{ [' + obj + '] ' + parts.join(', ') + ' }';`
	`78`	`+ if (parts.length === 0) return '[' + String(obj) + ']';`
	`79`	`+ return '{ [' + String(obj) + '] ' + parts.join(', ') + ' }';`
`80`	`80`	`}`
`81`	`81`	`else if (typeof obj === 'object' && typeof obj.inspect === 'function') {`
`82`	`82`	`return obj.inspect();`