Skip to content

Commit 450063b

Browse files
committed
Merge pull request #35 from sminnee/fix-sauce-connect
Fix Sauce Connect usage.
2 parents 5ff757c + c4bdca4 commit 450063b

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

lib/WebDriver/AbstractWebDriver.php

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,16 @@ protected function curl($requestMethod, $command, $parameters = null, $extraOpti
140140
throw WebDriverException::factory($results['status'], $message);
141141
}
142142

143-
return array('value' => $value, 'info' => $info);
143+
$return = array('value' => $value, 'info' => $info);
144+
145+
// Pass through the sessionId return value if it exists, failing over to webdriver.remote.sessionid in the val
146+
if(isset($results['sessionId'])) {
147+
$return['sessionId'] = $results['sessionId'];
148+
} else if(isset($value['webdriver.remote.sessionid'])) {
149+
$return['sessionId'] = $value['webdriver.remote.sessionid'];
150+
}
151+
152+
return $return;
144153
}
145154

146155
/**

lib/WebDriver/WebDriver.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@ public function session($requiredCapabilities = Browser::FIREFOX, $desiredCapabi
7575
array(CURLOPT_FOLLOWLOCATION => true)
7676
);
7777

78-
if (isset($results['value']['webdriver.remote.sessionid'])) {
79-
return new Session($this->url . '/session/' . $results['value']['webdriver.remote.sessionid']);
78+
if (isset($results['sessionId'])) {
79+
return new Session($this->url . '/session/' . $results['sessionId']);
8080
}
8181

8282
// backward compatibility fallback

0 commit comments

Comments
 (0)