Skip to content

Commit 910c990

Browse files
committed
Only use "final" keyword on classes that purely house consts
1 parent b79e278 commit 910c990

16 files changed

+16
-18
lines changed

lib/WebDriver/Alert.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
* @method array getText() Get Alert Text
3333
* @method array postText() Send Alert Text
3434
*/
35-
final class Alert extends AbstractWebDriver
35+
class Alert extends AbstractWebDriver
3636
{
3737
/**
3838
* {@inheritdoc}

lib/WebDriver/ApplicationCache.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
*
3030
* @method integer status() Get application cache status.
3131
*/
32-
final class ApplicationCache extends AbstractWebDriver
32+
class ApplicationCache extends AbstractWebDriver
3333
{
3434
/**
3535
* {@inheritdoc}

lib/WebDriver/Capability.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
*
2929
* @package WebDriver
3030
*/
31-
class Capability
31+
final class Capability
3232
{
3333
/**
3434
* Desired capabilities

lib/WebDriver/Frame.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
*
3030
* @method void parent() Change focus to the parent context.
3131
*/
32-
final class Frame extends AbstractWebDriver
32+
class Frame extends AbstractWebDriver
3333
{
3434
const WEB_FRAME_ID = 'frame-075b-4da1-b6ba-e579c2d3230a';
3535

lib/WebDriver/Ime.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
* @method array available_engines() List all available engines on the machines.
3434
* @method void deactivate() De-activates the currently active IME engine.
3535
*/
36-
final class Ime extends AbstractWebDriver
36+
class Ime extends AbstractWebDriver
3737
{
3838
/**
3939
* {@inheritdoc}

lib/WebDriver/LegacyWindow.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
* @method array getSize() Get size of the window.
3535
* @method void postSize($json) Change the size of the window.
3636
*/
37-
final class LegacyWindow extends AbstractWebDriver
37+
class LegacyWindow extends AbstractWebDriver
3838
{
3939
/**
4040
* Window handle

lib/WebDriver/Log.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
*
3030
* @method array types() Get available log types.
3131
*/
32-
final class Log extends AbstractWebDriver
32+
class Log extends AbstractWebDriver
3333
{
3434
/**
3535
* {@inheritdoc}

lib/WebDriver/SauceLabs/Capability.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,12 @@
2222

2323
namespace WebDriver\SauceLabs;
2424

25-
use WebDriver\Capability as BaseCapability;
26-
2725
/**
2826
* WebDriver\SauceLabs\Capability class
2927
*
3028
* @package WebDriver
3129
*/
32-
class Capability extends BaseCapability
30+
final class Capability
3331
{
3432
/**
3533
* Desired capabilities - SauceLabs

lib/WebDriver/ServiceFactory.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
*
3030
* @package WebDriver
3131
*/
32-
final class ServiceFactory
32+
class ServiceFactory
3333
{
3434
/**
3535
* singleton

lib/WebDriver/Session.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
* @method string window_handle() Retrieve the current window handle.
6363
* @method array window_handles() Retrieve the list of all window handles available to the session.
6464
*/
65-
final class Session extends Container
65+
class Session extends Container
6666
{
6767
/**
6868
* @var array

0 commit comments

Comments
 (0)