fuzz: remove unused TransactionsDelta validation interface

instagibbs · instagibbs · commit 4dfdf615b9db · 2024-11-20T13:44:49.000-05:00
diff --git a/src/test/fuzz/package_eval.cpp b/src/test/fuzz/package_eval.cpp
@@ -317,11 +317,6 @@ FUZZ_TARGET(ephemeral_package_eval, .init = initialize_tx_pool)
             }
         }
 
-        // Remember all added transactions
-        std::set<CTransactionRef> added;
-        auto txr = std::make_shared<TransactionsDelta>(added);
-        node.validation_signals->RegisterSharedValidationInterface(txr);
-
         auto single_submit = txs.size() == 1;
 
         const auto result_package = WITH_LOCK(::cs_main,
@@ -339,7 +334,6 @@ FUZZ_TARGET(ephemeral_package_eval, .init = initialize_tx_pool)
         }
 
         node.validation_signals->SyncWithValidationInterfaceQueue();
-        node.validation_signals->UnregisterSharedValidationInterface(txr);
 
         CheckMempoolEphemeralInvariants(tx_pool);
     }

Original file line number	Diff line number	Diff line change
`@@ -317,11 +317,6 @@ FUZZ_TARGET(ephemeral_package_eval, .init = initialize_tx_pool)`
`317`	`317`	`}`
`318`	`318`	`}`
`319`	`319`
`320`		`- // Remember all added transactions`
`321`		`- std::set<CTransactionRef> added;`
`322`		`- auto txr = std::make_shared<TransactionsDelta>(added);`
`323`		`- node.validation_signals->RegisterSharedValidationInterface(txr);`
`324`		`-`
`325`	`320`	`auto single_submit = txs.size() == 1;`
`326`	`321`
`327`	`322`	`const auto result_package = WITH_LOCK(::cs_main,`
`@@ -339,7 +334,6 @@ FUZZ_TARGET(ephemeral_package_eval, .init = initialize_tx_pool)`
`339`	`334`	`}`
`340`	`335`
`341`	`336`	`node.validation_signals->SyncWithValidationInterfaceQueue();`
`342`		`- node.validation_signals->UnregisterSharedValidationInterface(txr);`
`343`	`337`
`344`	`338`	`CheckMempoolEphemeralInvariants(tx_pool);`
`345`	`339`	`}`