Merge bitcoin#22657: fuzz: Re-enable assert in banman again

MarcoFalke · MarcoFalke · commit db94d74f2414 · 2021-08-07T16:28:50.000+02:00
fabed98 fuzz: Re-enable assert in banman again (MarcoFalke) Pull request description: Looks like this was accidentally fixed by removing the buggy code in commit efd6f90 ACKs for top commit: hebasto: ACK fabed98 Tree-SHA512: 2dea5dad48ff2050ae7086c1c6306c40f650e9629918e79adc54164a375d777a70b29f5a480566dc6430f07ce33dfe703fc5d45a20125584b4a026c5832198a2
diff --git a/src/test/fuzz/banman.cpp b/src/test/fuzz/banman.cpp
@@ -108,9 +108,7 @@ FUZZ_TARGET_INIT(banman, initialize_banman)
             BanMan ban_man_read{banlist_file, /* client_interface */ nullptr, /* default_ban_time */ 0};
             banmap_t banmap_read;
             ban_man_read.GetBanned(banmap_read);
-            // Assert temporarily disabled to allow the remainder of the fuzz test to run while a
-            // fix is being worked on. See https://github.com/bitcoin/bitcoin/pull/22517
-            (void)(banmap == banmap_read);
+            assert(banmap == banmap_read);
         }
     }
     fs::remove(banlist_file.string() + ".json");

Original file line number	Diff line number	Diff line change
`@@ -108,9 +108,7 @@ FUZZ_TARGET_INIT(banman, initialize_banman)`
`108`	`108`	`BanMan ban_man_read{banlist_file, /* client_interface / nullptr, / default_ban_time */ 0};`
`109`	`109`	`banmap_t banmap_read;`
`110`	`110`	`ban_man_read.GetBanned(banmap_read);`
`111`		`- // Assert temporarily disabled to allow the remainder of the fuzz test to run while a`
`112`		`- // fix is being worked on. See https://github.com/bitcoin/bitcoin/pull/22517`
`113`		`- (void)(banmap == banmap_read);`
	`111`	`+ assert(banmap == banmap_read);`
`114`	`112`	`}`
`115`	`113`	`}`
`116`	`114`	`fs::remove(banlist_file.string() + ".json");`