fix: enforced Node.js 18.19 as the minimum supported version (#2151)

BREAKING CHANGE:

Dropped support for Node.js versions below 18.19

Author: aryamohanan

package.json

@@ -19,7 +19,7 @@
   ],
   "license": "MIT",
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=18.19.0"
   },
   "contributors": [
     {

packages/autoprofile/package.json

@@ -56,7 +56,7 @@
     "semver": "^7.7.3"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=18.19.0"
   },
   "main": "index.js",
   "files": [

packages/aws-fargate/package.json

@@ -71,6 +71,6 @@
     "@instana/serverless": "4.30.1"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=18.19.0"
   }
 }

packages/aws-lambda/package.json

@@ -48,7 +48,7 @@
     "tracing"
   ],
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=18.19.0"
   },
   "contributors": [
     {

packages/azure-container-services/package.json

@@ -62,7 +62,7 @@
     "url": "https://github.com/instana/nodejs/issues"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=18.19.0"
   },
   "license": "MIT",
   "dependencies": {

packages/collector/package.json

@@ -31,7 +31,7 @@
     "url": "git+https://github.com/instana/nodejs.git"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=18.19.0"
   },
   "scripts": {
     "audit": "npm audit --omit=dev",

packages/core/src/tracing/instrumentation/protocols/nativeFetch.js

@@ -33,8 +33,7 @@ let isActive = false;
 exports.shouldAddHeadersToOptionsUnconditionally = function () {
   return (
     semver.eq(process.version, '21.0.0') ||
-    (semver.gte(process.version, '20.8.1') && semver.lt(process.version, '20.10.0')) ||
-    (semver.gte(process.version, '18.18.2') && semver.lt(process.version, '18.19.0'))
+    (semver.gte(process.version, '20.8.1') && semver.lt(process.version, '20.10.0'))
   );
 };
 

packages/core/src/util/nodeJsVersionCheck.js

@@ -4,10 +4,11 @@
 
 'use strict';
 
+const semver = require('semver');
 /**
  * This is the minimum required Node.js version for all @instana packages.
  */
-exports.minimumNodeJsVersion = 18;
+exports.minimumNodeJsVersion = '18.19.0';
 
 /**
  * Checks if the value of process.version denotes a Node.js version that is not supported, that is, older than the given
@@ -17,12 +18,9 @@ exports.minimumNodeJsVersion = 18;
  */
 exports.isNodeJsTooOld = function isNodeJsTooOld() {
   const currentVersion = process.version;
-  if (typeof currentVersion === 'string') {
-    const majorVersionStr = process.version.split('.')[0];
-    if (majorVersionStr.length > 1 && majorVersionStr.charAt(0) === 'v') {
-      const majorVersion = parseInt(majorVersionStr.substring(1), 10);
-      return !isNaN(majorVersion) && majorVersion < exports.minimumNodeJsVersion;
-    }
+  if (!semver.valid(currentVersion)) {
+    return false;
   }
-  return false;
+
+  return semver.lt(currentVersion, exports.minimumNodeJsVersion);
 };

packages/core/test/tracing/supportedVersion_test.js

@@ -11,12 +11,13 @@ const supportedTracingVersion = require('../../src/tracing/supportedVersion');
 
 describe('supported versions for Node.js auto tracing', () => {
   it('must support various Node.js versions', () => {
-    expect(supportedTracingVersion('18.1.1')).to.equal(true);
+    expect(supportedTracingVersion('18.19.0')).to.equal(true);
     expect(supportedTracingVersion('20.0.0')).to.equal(true);
     expect(supportedTracingVersion('21.2.0')).to.equal(true);
     expect(supportedTracingVersion('22.0.0')).to.equal(true);
     expect(supportedTracingVersion('23.0.0')).to.equal(true);
     expect(supportedTracingVersion('24.0.0')).to.equal(true);
+    expect(supportedTracingVersion('25.0.0')).to.equal(true);
   });
 
   it('must report various Node.js versions as not supported', () => {
@@ -45,5 +46,6 @@ describe('supported versions for Node.js auto tracing', () => {
     expect(supportedTracingVersion('12.0.0')).to.equal(false);
     expect(supportedTracingVersion('14.0.0')).to.equal(false);
     expect(supportedTracingVersion('16.1.0')).to.equal(false);
+    expect(supportedTracingVersion('18.18.0')).to.equal(false);
   });
 });

packages/core/test/util/nodeJsTooOld_test.js

@@ -77,6 +77,21 @@ describe('util.nodeJsTooOld', () => {
     expect(isNodeJsTooOld()).to.be.true;
   });
 
+  it('should reject Node.js 18.18.0', () => {
+    setProcessVersion('v18.18.0');
+    expect(isNodeJsTooOld()).to.be.true;
+  });
+
+  it('should reject Node.js 18.18.9', () => {
+    setProcessVersion('v18.18.0');
+    expect(isNodeJsTooOld()).to.be.true;
+  });
+
+  it('should accept Node.js 18.19.0', () => {
+    setProcessVersion('v18.19.0');
+    expect(isNodeJsTooOld()).to.be.false;
+  });
+
   it('should accept if process.version is not set', () => {
     setProcessVersion(undefined);
     expect(isNodeJsTooOld()).to.be.false;
@@ -94,7 +109,7 @@ describe('util.nodeJsTooOld', () => {
 
   it('should accept if process.version is in an unexpected format (no v prefix)', () => {
     setProcessVersion('11.22.33');
-    expect(isNodeJsTooOld()).to.be.false;
+    expect(isNodeJsTooOld()).to.be.true;
   });
 });