Skip to content

Commit 751c901

Browse files
committed
test: comments
1 parent fc0109f commit 751c901

File tree

3 files changed

+4
-4
lines changed
  • packages
    • collector/test/tracing/protocols/http/server
    • opentelemetry-exporter/test
    • opentelemetry-sampler/test

3 files changed

+4
-4
lines changed

packages/collector/test/tracing/protocols/http/server/test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,7 @@ function registerTests(agentControls, appUsesHttps, useHttp2CompatApi) {
471471
)
472472
));
473473

474-
// Skip this test because native fetch does not allow URLs with embedded credentials
474+
// Skipped this test because native fetch does not allow URLs with embedded credentials
475475
// Error: "Request cannot be constructed from a URL that includes credentials"
476476
// This is a security feature of the Fetch API standard
477477
it.skip(`must not collect credentials embedded in URLs (HTTPS: ${appUsesHttps})`, () =>
@@ -530,7 +530,7 @@ function registerTests(agentControls, appUsesHttps, useHttp2CompatApi) {
530530
})
531531
);
532532

533-
// The request will eventually complete after 4 seconds (as defined in app.js)
533+
// The request will eventually complete after 4 seconds
534534
return requestPromise.catch(() => {});
535535
});
536536

packages/opentelemetry-exporter/test/test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ function verifySpans(spans, appControls) {
212212
// NOTE: Native fetch with OpenTelemetry does not create an EXIT span for the HTTP client call
213213
// in older versions. Starting with @opentelemetry/auto-instrumentations-node v0.46+,
214214
// @opentelemetry/instrumentation-undici is included and enabled by default, which instruments
215-
// native fetch. However, this test may use an older version without undici instrumentation.
215+
// native fetch. However, this test use an older version without the instrumentation.
216216
// NOTE: middleware spans are not collected when migrating to express v5 because:
217217
// middleware initialization was removed in
218218
// https://github.com/expressjs/express/commit/78e50547f16e2adb5763a953586d05308d8aba4c.

packages/opentelemetry-sampler/test/test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ mochaSuiteFn('Instana OpenTelemetry Sampler', function () {
130130
// NOTE: Native fetch with OpenTelemetry does not create an EXIT span for the HTTP client call
131131
// in older versions. Starting with @opentelemetry/auto-instrumentations-node v0.46+,
132132
// @opentelemetry/instrumentation-undici is included and enabled by default, which instruments
133-
// native fetch. However, this test may use an older version without undici instrumentation.
133+
// native fetch. However, this test use an older version without undici instrumentation.
134134
const spanNames = ['tcp.connect', 'tls.connect', 'GET'];
135135
expect(spanNames).to.eql(resp.spans.map(s => s.name));
136136
expect(resp.spans.length).to.be.gte(3);

0 commit comments

Comments
 (0)