chore: reproduced + fixed

Author: kirrg001

packages/collector/test/tracing/misc/invalid_app/test.js

@@ -0,0 +1,42 @@
+/*
+ * (c) Copyright IBM Corp. 2025
+ */
+
+'use strict';
+
+const path = require('path');
+const childProcess = require('child_process');
+const expect = require('chai').expect;
+const supportedVersion = require('@instana/core').tracing.supportedVersion;
+const config = require('../../../../../core/test/config');
+const mochaSuiteFn = supportedVersion(process.versions.node) ? describe : describe.skip;
+
+mochaSuiteFn('tracing/invalidApp', function () {
+  this.timeout(config.getTestTimeout() * 3);
+
+  it('when the collector is required in interactive shell', cb => {
+    const child = childProcess.spawn(
+      process.execPath,
+      ['--require', path.join(__dirname, '..', '..', '..', '..', 'src', 'immediate.js')],
+      {
+        stdio: 'inherit',
+        cwd: process.cwd(),
+        env: process.env
+      }
+    );
+
+    child.on('error', err => {
+      cb(err);
+    });
+
+    child.on('exit', (code, signal) => {
+      expect(signal).to.equal('SIGTERM');
+      expect(code).to.not.exist;
+      cb();
+    });
+
+    setTimeout(() => {
+      child.kill('SIGTERM');
+    }, 3 * 1000);
+  });
+});

packages/core/src/util/applicationUnderMonitoring.js

@@ -187,12 +187,17 @@ function getMainPackageJsonPathStartingAtDirectory(startDirectory, cb) {
       }
     }
 
-    // In case if require.main or process.argv[1] might be missing or invalid,
-    // so mainModule.filename can be undefined.
+    // CASE: node --require .../src/immediate.js
     if (!mainModule?.filename) {
       logger.warn('Application entrypoint could not be identified. Package.json resolution will be skipped.');
-      return process.nextTick(cb);
+      const err = new Error('Application entrypoint could not be identified. Search for package.json failed.');
+
+      // @ts-ignore
+      err.code = 'INSTANA_NO_MAIN_MODULE';
+
+      return process.nextTick(cb, err, null);
     }
+
     startDirectory = path.dirname(mainModule.filename);
   }
 

packages/serverless-collector/src/metrics/name.js

@@ -21,10 +21,13 @@ module.exports = config => {
     return process.env.INSTANA_SERVICE_NAME;
   }
 
+  // TODO: all metrics call `getMainPackageJsonStartingAtMainModule` - if `getMainPackageJsonStartingAtMainModule` fails
+  //       for the 1st metrics, the other metrics will try again...we should initiate
+  //       `getMainPackageJsonStartingAtMainModule` only once in a central place!
   return new Promise(resolve => {
     instanaCore.util.applicationUnderMonitoring.getMainPackageJsonStartingAtMainModule((err, packageJson) => {
       if (err) {
-        logger.debug(`Failed to determine main package.json. ${err?.message} ${err?.stack}`);
+        logger.debug(`Failed to determine main package.json for "name" metric. ${err?.message} ${err?.stack}`);
         return resolve();
       }
 

packages/shared-metrics/src/description.js

@@ -5,6 +5,8 @@
 
 'use strict';
 
+const { payloadPrefix } = require('./activeHandles');
+
 const { applicationUnderMonitoring } = require('@instana/core').util;
 
 /** @type {import('@instana/core/src/core').GenericLogger} */
@@ -28,9 +30,14 @@ let attempts = 0;
 exports.activate = function activate() {
   attempts++;
 
+  // TODO: all metrics call `getMainPackageJsonStartingAtMainModule` - if `getMainPackageJsonStartingAtMainModule` fails
+  //       for the 1st metrics, the other metrics will try again...we should initiate
+  //       `getMainPackageJsonStartingAtMainModule` only once in a central place!
   applicationUnderMonitoring.getMainPackageJsonStartingAtMainModule((err, packageJson) => {
     if (err) {
-      return logger.warn(`Failed to determine main package json. Reason: ${err?.message} ${err?.stack}`);
+      return logger.warn(
+        `Failed to determine main package.json for "${payloadPrefix}" metric. Reason: ${err?.message} ${err?.stack}`
+      );
     } else if (!packageJson && attempts < MAX_ATTEMPTS) {
       setTimeout(exports.activate, DELAY).unref();
       return;

packages/shared-metrics/src/keywords.js

@@ -29,9 +29,15 @@ let attempts = 0;
 exports.activate = function activate() {
   attempts++;
 
+  // TODO: all metrics call `getMainPackageJsonStartingAtMainModule` - if `getMainPackageJsonStartingAtMainModule` fails
+  //       for the 1st metrics, the other metrics will try again...we should initiate
+  //       `getMainPackageJsonStartingAtMainModule` only once in a central place!
   applicationUnderMonitoring.getMainPackageJsonStartingAtMainModule((err, packageJson) => {
     if (err) {
-      return logger.warn(`Failed to determine main package json. Reason: ${err?.message} ${err?.stack}`);
+      return logger.warn(
+        // eslint-disable-next-line max-len
+        `Failed to determine main package.json for "${exports.payloadPrefix}" metric. Reason: ${err?.message} ${err?.stack}`
+      );
     } else if (!packageJson && attempts < MAX_ATTEMPTS) {
       setTimeout(exports.activate, DELAY).unref();
 

packages/shared-metrics/src/name.js

@@ -28,9 +28,14 @@ let attempts = 0;
 exports.activate = function activate() {
   attempts++;
 
+  // TODO: all metrics call `getMainPackageJsonStartingAtMainModule` - if `getMainPackageJsonStartingAtMainModule` fails
+  //       for the 1st metrics, the other metrics will try again...we should initiate
+  //       `getMainPackageJsonStartingAtMainModule` only once in a central place!
   applicationUnderMonitoring.getMainPackageJsonStartingAtMainModule((err, packageJson) => {
     if (err) {
-      return logger.warn(`Failed to determine main package json. Reason: ${err?.message} ${err?.stack}`);
+      return logger.warn(
+        `Failed to determine main package.json for "${exports.payloadPrefix}". Reason: ${err?.message} ${err?.stack}`
+      );
     } else if (!packageJson && attempts < exports.MAX_ATTEMPTS) {
       logger.debug('Main package.json could not be found. Will try again later.');
       setTimeout(exports.activate, exports.DELAY).unref();

packages/shared-metrics/src/version.js

@@ -28,9 +28,15 @@ let attempts = 0;
 exports.activate = function activate() {
   attempts++;
 
+  // TODO: all metrics call `getMainPackageJsonStartingAtMainModule` - if `getMainPackageJsonStartingAtMainModule` fails
+  //       for the 1st metrics, the other metrics will try again...we should initiate
+  //       `getMainPackageJsonStartingAtMainModule` only once in a central place!
   applicationUnderMonitoring.getMainPackageJsonStartingAtMainModule((err, packageJson) => {
     if (err) {
-      return logger.warn(`Failed to determine main package json. Reason: ${err?.message} ${err?.stack}`);
+      return logger.warn(
+        // eslint-disable-next-line max-len
+        `Failed to determine main package.json for "${exports.payloadPrefix}" metric. Reason: ${err?.message} ${err?.stack}`
+      );
     } else if (!packageJson && attempts < MAX_ATTEMPTS) {
       setTimeout(exports.activate, DELAY).unref();