chore: added semver

Author: aryamohanan

packages/core/src/util/nodeJsVersionCheck.js

@@ -4,6 +4,7 @@
 
 'use strict';
 
+const semver = require('semver');
 /**
  * This is the minimum required Node.js version for all @instana packages.
  */
@@ -17,23 +18,9 @@ exports.minimumNodeJsVersion = '18.19.0';
  */
 exports.isNodeJsTooOld = function isNodeJsTooOld() {
   const currentVersion = process.version;
-  if (typeof currentVersion === 'string') {
-    const parts = currentVersion.split('.');
-    const majorVersionStr = parts[0];
-    if (majorVersionStr.length > 1 && majorVersionStr.charAt(0) === 'v') {
-      const major = parseInt(majorVersionStr.slice(1), 10);
-      const minor = parseInt(parts[1], 10);
-      const patch = parseInt(parts[2], 10);
-
-      if (isNaN(major) || isNaN(minor) || isNaN(patch)) return false;
-
-      const [minMajor, minMinor, minPatch] = exports.minimumNodeJsVersion.split('.').map(Number);
-      return (
-        major < minMajor ||
-        (major === minMajor && minor < minMinor) ||
-        (major === minMajor && minor === minMinor && patch < minPatch)
-      );
-    }
+  if (!semver.valid(currentVersion)) {
+    return false;
   }
-  return false;
+
+  return semver.lt(currentVersion, exports.minimumNodeJsVersion);
 };

packages/core/test/util/nodeJsTooOld_test.js

@@ -109,7 +109,7 @@ describe('util.nodeJsTooOld', () => {
 
   it('should accept if process.version is in an unexpected format (no v prefix)', () => {
     setProcessVersion('11.22.33');
-    expect(isNodeJsTooOld()).to.be.false;
+    expect(isNodeJsTooOld()).to.be.true;
   });
 });