Skip to content

Commit d50a76f

Browse files
authored
fix: dropped support for kafka-avro (#2141)
- No updates or releases in over 5 years - Very few downloads (around 100+) - No Instana customers using it - Supports only Node.js up to v14, which we’ve already dropped in v4 - Already we deprecated an year ago the warning also added. ref: https://jsw.ibm.com/browse/INSTA-63921
1 parent 7d4e326 commit d50a76f

16 files changed

+25
-645
lines changed

.tekton/assets/sidecars.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@
105105
"command": ["/bin/bash"],
106106
"args": [
107107
"-lc",
108-
"kafka_server=\"0.0.0.0:9092\"; kafka_topics=\"test test-topic test-batch-topic rdkafka-topic kafka-avro-topic\"; until kafka-topics --bootstrap-server \"$kafka_server\" --list >/dev/null 2>&1; do echo 'waiting for Kafka...'; sleep 2; done; for t in $kafka_topics; do kafka-topics --bootstrap-server \"$kafka_server\" --create --if-not-exists --topic \"$t\"; done; echo 'All topics created.'"
108+
"kafka_server=\"0.0.0.0:9092\"; kafka_topics=\"test test-topic test-batch-topic rdkafka-topic\"; until kafka-topics --bootstrap-server \"$kafka_server\" --list >/dev/null 2>&1; do echo 'waiting for Kafka...'; sleep 2; done; for t in $kafka_topics; do kafka-topics --bootstrap-server \"$kafka_server\" --create --if-not-exists --topic \"$t\"; done; echo 'All topics created.'"
109109
]
110110
},
111111
{

.tekton/tasks/test-groups/collector-tracing-messaging-split-2-task.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ spec:
4545
imagePullPolicy: IfNotPresent
4646
args:
4747
- "-lc"
48-
- "kafka_server=\"0.0.0.0:9092\"; kafka_topics=\"test test-topic test-batch-topic rdkafka-topic kafka-avro-topic\"; until kafka-topics --bootstrap-server \"$kafka_server\" --list >/dev/null 2>&1; do echo 'waiting for Kafka...'; sleep 2; done; for t in $kafka_topics; do kafka-topics --bootstrap-server \"$kafka_server\" --create --if-not-exists --topic \"$t\"; done; echo 'All topics created.'"
48+
- "kafka_server=\"0.0.0.0:9092\"; kafka_topics=\"test test-topic test-batch-topic rdkafka-topic\"; until kafka-topics --bootstrap-server \"$kafka_server\" --list >/dev/null 2>&1; do echo 'waiting for Kafka...'; sleep 2; done; for t in $kafka_topics; do kafka-topics --bootstrap-server \"$kafka_server\" --create --if-not-exists --topic \"$t\"; done; echo 'All topics created.'"
4949
command:
5050
- "/bin/bash"
5151
- name: schema-registry

.tekton/tasks/test-groups/collector-tracing-messaging-split-3-task.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ spec:
4545
imagePullPolicy: IfNotPresent
4646
args:
4747
- "-lc"
48-
- "kafka_server=\"0.0.0.0:9092\"; kafka_topics=\"test test-topic test-batch-topic rdkafka-topic kafka-avro-topic\"; until kafka-topics --bootstrap-server \"$kafka_server\" --list >/dev/null 2>&1; do echo 'waiting for Kafka...'; sleep 2; done; for t in $kafka_topics; do kafka-topics --bootstrap-server \"$kafka_server\" --create --if-not-exists --topic \"$t\"; done; echo 'All topics created.'"
48+
- "kafka_server=\"0.0.0.0:9092\"; kafka_topics=\"test test-topic test-batch-topic rdkafka-topic\"; until kafka-topics --bootstrap-server \"$kafka_server\" --list >/dev/null 2>&1; do echo 'waiting for Kafka...'; sleep 2; done; for t in $kafka_topics; do kafka-topics --bootstrap-server \"$kafka_server\" --create --if-not-exists --topic \"$t\"; done; echo 'All topics created.'"
4949
command:
5050
- "/bin/bash"
5151
- name: schema-registry

.tekton/tasks/test-groups/collector-tracing-messaging-split-4-task.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ spec:
4545
imagePullPolicy: IfNotPresent
4646
args:
4747
- "-lc"
48-
- "kafka_server=\"0.0.0.0:9092\"; kafka_topics=\"test test-topic test-batch-topic rdkafka-topic kafka-avro-topic\"; until kafka-topics --bootstrap-server \"$kafka_server\" --list >/dev/null 2>&1; do echo 'waiting for Kafka...'; sleep 2; done; for t in $kafka_topics; do kafka-topics --bootstrap-server \"$kafka_server\" --create --if-not-exists --topic \"$t\"; done; echo 'All topics created.'"
48+
- "kafka_server=\"0.0.0.0:9092\"; kafka_topics=\"test test-topic test-batch-topic rdkafka-topic\"; until kafka-topics --bootstrap-server \"$kafka_server\" --list >/dev/null 2>&1; do echo 'waiting for Kafka...'; sleep 2; done; for t in $kafka_topics; do kafka-topics --bootstrap-server \"$kafka_server\" --create --if-not-exists --topic \"$t\"; done; echo 'All topics created.'"
4949
command:
5050
- "/bin/bash"
5151
- name: schema-registry

.tekton/tasks/test-groups/collector-tracing-messaging-split-5-task.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ spec:
4545
imagePullPolicy: IfNotPresent
4646
args:
4747
- "-lc"
48-
- "kafka_server=\"0.0.0.0:9092\"; kafka_topics=\"test test-topic test-batch-topic rdkafka-topic kafka-avro-topic\"; until kafka-topics --bootstrap-server \"$kafka_server\" --list >/dev/null 2>&1; do echo 'waiting for Kafka...'; sleep 2; done; for t in $kafka_topics; do kafka-topics --bootstrap-server \"$kafka_server\" --create --if-not-exists --topic \"$t\"; done; echo 'All topics created.'"
48+
- "kafka_server=\"0.0.0.0:9092\"; kafka_topics=\"test test-topic test-batch-topic rdkafka-topic\"; until kafka-topics --bootstrap-server \"$kafka_server\" --list >/dev/null 2>&1; do echo 'waiting for Kafka...'; sleep 2; done; for t in $kafka_topics; do kafka-topics --bootstrap-server \"$kafka_server\" --create --if-not-exists --topic \"$t\"; done; echo 'All topics created.'"
4949
command:
5050
- "/bin/bash"
5151
- name: schema-registry

.tekton/tasks/test-groups/collector-tracing-messaging-split-6-task.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ spec:
4545
imagePullPolicy: IfNotPresent
4646
args:
4747
- "-lc"
48-
- "kafka_server=\"0.0.0.0:9092\"; kafka_topics=\"test test-topic test-batch-topic rdkafka-topic kafka-avro-topic\"; until kafka-topics --bootstrap-server \"$kafka_server\" --list >/dev/null 2>&1; do echo 'waiting for Kafka...'; sleep 2; done; for t in $kafka_topics; do kafka-topics --bootstrap-server \"$kafka_server\" --create --if-not-exists --topic \"$t\"; done; echo 'All topics created.'"
48+
- "kafka_server=\"0.0.0.0:9092\"; kafka_topics=\"test test-topic test-batch-topic rdkafka-topic\"; until kafka-topics --bootstrap-server \"$kafka_server\" --list >/dev/null 2>&1; do echo 'waiting for Kafka...'; sleep 2; done; for t in $kafka_topics; do kafka-topics --bootstrap-server \"$kafka_server\" --create --if-not-exists --topic \"$t\"; done; echo 'All topics created.'"
4949
command:
5050
- "/bin/bash"
5151
- name: schema-registry

.tekton/tasks/test-groups/collector-tracing-messaging-task.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ spec:
4545
imagePullPolicy: IfNotPresent
4646
args:
4747
- "-lc"
48-
- "kafka_server=\"0.0.0.0:9092\"; kafka_topics=\"test test-topic test-batch-topic rdkafka-topic kafka-avro-topic\"; until kafka-topics --bootstrap-server \"$kafka_server\" --list >/dev/null 2>&1; do echo 'waiting for Kafka...'; sleep 2; done; for t in $kafka_topics; do kafka-topics --bootstrap-server \"$kafka_server\" --create --if-not-exists --topic \"$t\"; done; echo 'All topics created.'"
48+
- "kafka_server=\"0.0.0.0:9092\"; kafka_topics=\"test test-topic test-batch-topic rdkafka-topic\"; until kafka-topics --bootstrap-server \"$kafka_server\" --list >/dev/null 2>&1; do echo 'waiting for Kafka...'; sleep 2; done; for t in $kafka_topics; do kafka-topics --bootstrap-server \"$kafka_server\" --create --if-not-exists --topic \"$t\"; done; echo 'All topics created.'"
4949
command:
5050
- "/bin/bash"
5151
- name: schema-registry

bin/dependencies/utils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ exports.getLatestVersion = ({ pkgName, installedVersion, isBeta, fromInstalledMa
128128
}
129129
}
130130

131-
// e.g. kafka-avro released a wrong order of versions
131+
// some packages released a wrong order of versions
132132
if (installedVersion && semver.lt(latestVersion, installedVersion)) {
133133
return installedVersion;
134134
}

currencies.json

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -747,17 +747,6 @@
747747
"note": "",
748748
"core": false
749749
},
750-
{
751-
"name": "kafka-avro",
752-
"policy": "Deprecated",
753-
"lastSupportedVersion": "",
754-
"latestVersion": "",
755-
"cloudNative": false,
756-
"isBeta": false,
757-
"ignoreUpdates": false,
758-
"note": "",
759-
"core": false
760-
},
761750
{
762751
"name": "node-rdkafka",
763752
"policy": "45-days",

docker-compose-base.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ services:
122122
set -euo pipefail
123123
124124
kafka_server="kafka:29092"
125-
kafka_topics="test test-topic test-batch-topic rdkafka-topic kafka-avro-topic"
125+
kafka_topics="test test-topic test-batch-topic rdkafka-topic"
126126
127127
echo "Waiting for Kafka to be ready on $$kafka_server..."
128128

0 commit comments

Comments
 (0)