Skip to content

Commit e38a15a

Browse files
committed
test: added span length assertions for mysql tests
1 parent 5491461 commit e38a15a

File tree

1 file changed

+16
-2
lines changed
  • packages/collector/test/tracing/database/mysql

1 file changed

+16
-2
lines changed

packages/collector/test/tracing/database/mysql/test.js

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ function registerSuite(agentControls, driverMode, useExecute) {
4646
env.USE_EXECUTE = 'true';
4747
}
4848

49-
test(env, agentControls);
49+
test(env, agentControls, driverMode);
5050
});
5151

5252
describe('suppressed', function () {
@@ -102,7 +102,7 @@ function registerSuite(agentControls, driverMode, useExecute) {
102102
});
103103
}
104104

105-
function test(env, agentControls) {
105+
function test(env, agentControls, driverMode) {
106106
let controls;
107107

108108
before(async () => {
@@ -139,6 +139,11 @@ function test(env, agentControls) {
139139
.then(() =>
140140
testUtils.retry(() =>
141141
agentControls.getSpans().then(spans => {
142+
// 1 x mysql
143+
// 1 x httpserver
144+
// 1 x otel fs(not included in mysql2/promise)
145+
const expectedSpanCount = driverMode === 'mysql2/promises' ? 2 : 3;
146+
expect(spans.length).to.equal(expectedSpanCount);
142147
const entrySpan = testUtils.expectAtLeastOneMatching(spans, [
143148
span => expect(span.n).to.equal('node.http.server'),
144149
span => expect(span.f.e).to.equal(String(controls.getPid())),
@@ -181,6 +186,9 @@ function test(env, agentControls) {
181186

182187
return testUtils.retry(() =>
183188
agentControls.getSpans().then(spans => {
189+
// 2 x mysql
190+
// 2 x httpserver
191+
expect(spans.length).to.equal(4);
184192
const postEntrySpan = testUtils.expectAtLeastOneMatching(spans, [
185193
span => expect(span.n).to.equal('node.http.server'),
186194
span => expect(span.f.e).to.equal(String(controls.getPid())),
@@ -245,6 +253,12 @@ function test(env, agentControls) {
245253

246254
return testUtils.retry(() =>
247255
agentControls.getSpans().then(spans => {
256+
// 1 x mysql
257+
// 1 x httpserver
258+
// 1 x httpclient
259+
// 1 x otel fs(included in mysql2/promise)
260+
const expectedSpanCount = driverMode === 'mysql2/promises' ? 4 : 3;
261+
expect(spans.length).to.equal(expectedSpanCount);
248262
const postEntrySpan = testUtils.expectAtLeastOneMatching(spans, [
249263
span => expect(span.n).to.equal('node.http.server'),
250264
span => expect(span.f.e).to.equal(String(controls.getPid())),

0 commit comments

Comments
 (0)