Skip to content

Commit ecb81b7

Browse files
chore: avoid hardcoding and use span name
1 parent 5bb9017 commit ecb81b7

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

packages/core/src/tracing/instrumentation/databases/mysql.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ function instrumentedAccessFunction(
190190
})
191191
.catch(error => {
192192
span.ec = 1;
193-
tracingUtil.setErrorStack(span, error, 'mysql');
193+
tracingUtil.setErrorStack(span, error, exports.spanName);
194194

195195
span.d = Date.now() - span.ts;
196196
span.transmit();
@@ -205,7 +205,7 @@ function instrumentedAccessFunction(
205205
function onResult(error) {
206206
if (error) {
207207
span.ec = 1;
208-
tracingUtil.setErrorStack(span, error, 'mysql');
208+
tracingUtil.setErrorStack(span, error, exports.spanName);
209209
}
210210

211211
span.d = Date.now() - span.ts;

packages/core/src/tracing/instrumentation/databases/pgNative.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,7 @@ function startSpanBeforeSync(ctx, originalFn, originalArgs, statement, stackTrac
197197
function finishSpan(error, span) {
198198
if (error) {
199199
span.ec = 1;
200-
span.data.pg.error = tracingUtil.getErrorDetails(error);
201-
tracingUtil.setErrorStack(span, error, 'pg');
200+
tracingUtil.setErrorStack(span, error, exports.spanName);
202201
}
203202

204203
span.d = Date.now() - span.ts;

packages/core/src/tracing/instrumentation/protocols/httpClient.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ function instrument(coreModule, forceHttps) {
276276
};
277277
span.d = Date.now() - span.ts;
278278
span.ec = 1;
279-
tracingUtil.setErrorStack(span, e, 'http');
279+
tracingUtil.setErrorStack(span, e, exports.spanName);
280280

281281
span.transmit();
282282
throw e;
@@ -326,7 +326,7 @@ function instrument(coreModule, forceHttps) {
326326
};
327327
span.d = Date.now() - span.ts;
328328
span.ec = 1;
329-
tracingUtil.setErrorStack(span, err, 'http');
329+
tracingUtil.setErrorStack(span, err, exports.spanName);
330330

331331
span.transmit();
332332
});

0 commit comments

Comments
 (0)