Skip to content

Commit 1d2649f

Browse files
committed
Mark span as errored when response code 500-511
1 parent f1aacd2 commit 1d2649f

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

instana/django.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ def __call__(self, request):
3131

3232
response = self.get_response(request)
3333

34+
if 500 <= response.status_code <= 511:
35+
span.SetTag(ext.Error, True)
36+
3437
span.set_tag(ext.HTTP_STATUS_CODE, response.status_code)
3538
ot.global_tracer.inject(span.context, ot.Format.HTTP_HEADERS, response)
3639
span.finish()

instana/django19.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ def process_request(self, request):
3131

3232
def process_response(self, request, response):
3333
if self.span:
34+
if 500 <= response.status_code <= 511:
35+
self.span.SetTag(ext.Error, True)
36+
3437
self.span.set_tag(ext.HTTP_STATUS_CODE, response.status_code)
3538
ot.global_tracer.inject(self.span.context, ot.Format.HTTP_HEADERS, response)
3639
self.span.finish()

instana/wsgi.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,12 @@ def new_start_response(status, headers, exc_info=None):
2020
"""Modified start response with additional headers."""
2121
ot.global_tracer.inject(span.context, ot.Format.HTTP_HEADERS, headers)
2222
res = start_response(status, headers, exc_info)
23-
span.set_tag(ext.HTTP_STATUS_CODE, status.split(' ')[0])
23+
24+
sc = status.split(' ')[0]
25+
if 500 <= int(sc) <= 511:
26+
span.SetTag(ext.Error, True)
27+
28+
span.set_tag(ext.HTTP_STATUS_CODE, sc)
2429
span.finish()
2530
return res
2631

0 commit comments

Comments
 (0)