Improved Logger Naming & Formatting (#82)

* Use appropriate Logger formatting & naming

* Warn only once when Host agent not found

On boot if the Host agent is not found, the following
message will be output only once to reduce log spam (warn level)

"Instana Host agent not found.  Will retry periodically..."

Previously this message was emitted on INFO level every 30 seconds.

Author: pglombardo

instana/fsm.py

@@ -36,6 +36,8 @@ class Fsm(object):
     fsm = None
     timer = None
 
+    warnedPeriodic = False
+
     def __init__(self, agent):
         log.info("Stan is on the scene.  Starting Instana instrumentation version", instana.__version__)
         log.debug("initializing fsm")
@@ -104,7 +106,10 @@ def lookup_agent_host(self, e):
                     self.fsm.announce()
                     return True
 
-        log.info("Instana Host Agent couldn't be found. Scheduling retry.")
+        if (self.warnedPeriodic is False):
+            log.warn("Instana Host Agent couldn't be found. Will retry periodically...")
+            self.warnedPeriodic = True
+
         self.schedule_retry(self.lookup_agent_host, e, "agent_lookup")
         return False
 

instana/log.py

@@ -1,12 +1,11 @@
 import logging as log
 import os
 
-logger = log.getLogger('instana(' + str(os.getpid()) + ')')
-
+logger = log.getLogger('instana')
 
 def init(level):
     ch = log.StreamHandler()
-    f = log.Formatter('%(asctime)s: %(levelname)s: %(name)s: %(message)s')
+    f = log.Formatter('%(asctime)s: %(process)d %(levelname)s %(name)s: %(message)s')
     ch.setFormatter(f)
     logger.addHandler(ch)
     if "INSTANA_DEV" in os.environ: