Skip to content

Commit 675829b

Browse files
pvitalFerenc-
authored andcommitted
chore[fix]: Fix test_boto3_secretsmanager.py
After upgrading moto to the most recent version, the test containing the put_secret_value() method started to fail. As described in the boto3 documentation https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/secretsmanager.html#SecretsManager.Client.put_secret_value if a "the secret doesn't already exist, use CreateSecret() instead." Signed-off-by: Paulo Vital <[email protected]>
1 parent 75d8ecf commit 675829b

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

tests/clients/boto3/test_boto3_secretsmanager.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,20 +41,20 @@ def test_vanilla_list_secrets(secretsmanager):
4141

4242
def test_get_secret_value(secretsmanager):
4343
result = None
44+
secret_id = 'Uber_Password'
4445

45-
secretsmanager.put_secret_value(
46-
SecretId='Uber_Password',
46+
response = secretsmanager.create_secret(
47+
Name=secret_id,
4748
SecretBinary=b'password1',
4849
SecretString='password1',
49-
VersionStages=[
50-
'string',
51-
]
5250
)
53-
51+
52+
assert response['Name'] == secret_id
53+
5454
with tracer.start_active_span('test'):
55-
result = secretsmanager.get_secret_value(SecretId="Uber_Password")
55+
result = secretsmanager.get_secret_value(SecretId=secret_id)
5656

57-
assert result['Name'] == 'Uber_Password'
57+
assert result['Name'] == secret_id
5858

5959
spans = tracer.recorder.queued_spans()
6060
assert len(spans) == 2

0 commit comments

Comments
 (0)