- use unittest assert statements

- capture a list of headers

Signed-off-by: Varsha GS <[email protected]>

Author: GSVarsha

instana/instrumentation/asgi.py

@@ -20,13 +20,14 @@ def __init__(self, app):
         self.app = app
 
     def _extract_custom_headers(self, span, headers):
+        if agent.options.extra_http_headers is None:
+            return        
         try:
-            if agent.options.extra_http_headers is not None:
-                for custom_header in agent.options.extra_http_headers:
-                    # Headers are in the following format: b'x-header-1'
-                    for header_pair in headers:
-                        if header_pair[0].decode('utf-8').lower() == custom_header.lower():
-                            span.set_tag("http.header.%s" % custom_header, header_pair[1].decode('utf-8'))
+            for custom_header in agent.options.extra_http_headers:
+                # Headers are in the following format: b'x-header-1'
+                for header_pair in headers:
+                    if header_pair[0].decode('utf-8').lower() == custom_header.lower():
+                        span.set_tag("http.header.%s" % custom_header, header_pair[1].decode('utf-8'))
         except Exception:
             logger.debug("extract_custom_headers: ", exc_info=True)
 

tests/apps/fastapi_app/app.py

@@ -26,8 +26,11 @@ async def user(user_id):
 
 @fastapi_server.get("/response_headers")
 async def response_headers():
-    headers = {'X-Capture-This-Too': 'this too'}
-    return Response(content=None, headers=headers)
+    headers = {
+        'X-Capture-This-Too': 'this too',
+        'X-Capture-That-Too': 'that too'
+    }
+    return Response("Stan wuz here with headers!", headers=headers)
 
 @fastapi_server.get("/400")
 async def four_zero_zero():