Skip to content

Commit cd2b22f

Browse files
GSVarshaFerenc-
authored andcommitted
ci: Include testing with latest starlette version
Signed-off-by: Varsha GS <[email protected]>
1 parent 6cb776e commit cd2b22f

File tree

12 files changed

+25
-22
lines changed

12 files changed

+25
-22
lines changed

.circleci/config.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ commands:
5656
INSTANA_TEST: "true"
5757
CASSANDRA_TEST: "<<parameters.cassandra>>"
5858
COUCHBASE_TEST: "<<parameters.couchbase>>"
59-
GEVENT_TEST: "<<parameters.gevent>>"
59+
GEVENT_STARLETTE_TEST: "<<parameters.gevent>>"
6060
command: |
6161
. venv/bin/activate
6262
coverage run --source=instana -m pytest -v --junitxml=test-results <<parameters.tests>>
@@ -329,17 +329,17 @@ jobs:
329329
- store-pytest-results
330330
- run_sonarqube
331331

332-
py39gevent:
332+
py39gevent_starlette:
333333
docker:
334334
- image: cimg/python:3.9.17
335335
working_directory: ~/repo
336336
steps:
337337
- checkout
338338
- pip-install-deps:
339-
requirements: "tests/requirements-gevent.txt"
339+
requirements: "tests/requirements-gevent-starlette.txt"
340340
- run-tests-with-coverage-report:
341341
gevent: "true"
342-
tests: "tests/frameworks/test_gevent.py"
342+
tests: "tests/frameworks/test_gevent.py tests/frameworks/test_starlette.py"
343343
- store-pytest-results
344344
- store-coverage-report
345345

@@ -355,7 +355,7 @@ workflows:
355355
- python312
356356
- py39cassandra
357357
- py39couchbase
358-
- py39gevent
358+
- py39gevent_starlette
359359
- final_job:
360360
requires:
361361
- python37
@@ -366,4 +366,4 @@ workflows:
366366
- python312
367367
- py39cassandra
368368
- py39couchbase
369-
- py39gevent
369+
- py39gevent_starlette

.tekton/github-pr-pipeline.yaml.part

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ spec:
2626
- unittest-default
2727
- unittest-cassandra
2828
- unittest-couchbase
29-
- unittest-gevent
29+
- unittest-gevent-starlette
3030
taskRef:
3131
kind: Task
3232
name: github-set-status

.tekton/pipeline.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ spec:
7070
workspaces:
7171
- name: task-pvc
7272
workspace: python-tracer-ci-pipeline-pvc
73-
- name: unittest-gevent
73+
- name: unittest-gevent-starlette
7474
runAfter:
7575
- clone
7676
matrix:
@@ -80,7 +80,7 @@ spec:
8080
# 3.9.18-bookworm
8181
- "sha256:530d4ba717be787c0e2d011aa107edac6d721f8c06fe6d44708d4aa5e9bc5ec9"
8282
taskRef:
83-
name: python-tracer-unittest-gevent-task
83+
name: python-tracer-unittest-gevent-starlette-task
8484
workspaces:
8585
- name: task-pvc
8686
workspace: python-tracer-ci-pipeline-pvc

.tekton/run_unittests.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,13 @@ couchbase)
3636
export REQUIREMENTS='requirements-couchbase.txt'
3737
export TESTS='tests/clients/test_couchbase.py'
3838
export COUCHBASE_TEST='true' ;;
39-
gevent)
40-
export REQUIREMENTS='requirements-gevent.txt'
41-
export TESTS='tests/frameworks/test_gevent.py'
42-
export GEVENT_TEST='true' ;;
39+
gevent_starlette)
40+
export REQUIREMENTS='requirements-gevent-starlette.txt'
41+
export TESTS='tests/frameworks/test_gevent.py tests/frameworks/test_starlette.py'
42+
export GEVENT_STARLETTE_TEST='true' ;;
4343
*)
4444
echo "ERROR \$TEST_CONFIGURATION='${TEST_CONFIGURATION}' is unsupported " \
45-
"not in (default|cassandra|couchbase|gevent)" >&2
45+
"not in (default|cassandra|couchbase|gevent_starlette)" >&2
4646
exit 3 ;;
4747
esac
4848

.tekton/task.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ spec:
9494
apiVersion: tekton.dev/v1
9595
kind: Task
9696
metadata:
97-
name: python-tracer-unittest-gevent-task
97+
name: python-tracer-unittest-gevent-starlette-task
9898
spec:
9999
params:
100100
- name: imageDigest
@@ -107,7 +107,7 @@ spec:
107107
image: python@$(params.imageDigest)
108108
env:
109109
- name: TEST_CONFIGURATION
110-
value: gevent
110+
value: gevent_starlette
111111
workingDir: /workspace/python-sensor/
112112
command:
113113
- /workspace/python-sensor/.tekton/run_unittests.sh

tests/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
os.environ["INSTANA_TEST"] = "true"
77

8-
if os.environ.get('GEVENT_TEST'):
8+
if os.environ.get('GEVENT_STARLETTE_TEST'):
99
from gevent import monkey
1010
monkey.patch_all()
1111

tests/apps/aiohttp_app/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
APP_THREAD = None
1010

11-
if not any((os.environ.get('GEVENT_TEST'),
11+
if not any((os.environ.get('GEVENT_STARLETTE_TEST'),
1212
os.environ.get('CASSANDRA_TEST'),
1313
sys.version_info < (3, 5, 3))):
1414
APP_THREAD = launch_background_thread(server, "AIOHTTP")

tests/apps/grpc_server/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import time
77
import threading
88

9-
if not any((os.environ.get('GEVENT_TEST'),
9+
if not any((os.environ.get('GEVENT_STARLETTE_TEST'),
1010
os.environ.get('CASSANDRA_TEST'),
1111
sys.version_info < (3, 5, 3))):
1212
# Background RPC application

tests/apps/tornado_server/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
app_thread = None
1010

11-
if not any((app_thread, os.environ.get('GEVENT_TEST'), os.environ.get('CASSANDRA_TEST'))):
11+
if not any((app_thread, os.environ.get('GEVENT_STARLETTE_TEST'), os.environ.get('CASSANDRA_TEST'))):
1212
testenv["tornado_port"] = 10813
1313
testenv["tornado_server"] = ("http://127.0.0.1:" + str(testenv["tornado_port"]))
1414

tests/conftest.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,9 @@
2222
if not os.environ.get("COUCHBASE_TEST"):
2323
collect_ignore_glob.append("*test_couchbase*")
2424

25-
if not os.environ.get("GEVENT_TEST"):
25+
if not os.environ.get("GEVENT_STARLETTE_TEST"):
2626
collect_ignore_glob.append("*test_gevent*")
27+
collect_ignore_glob.append("*test_starlette*")
2728

2829
# Python 3.10 support is incomplete yet
2930
# TODO: Remove this once we start supporting Tornado >= 6.0

0 commit comments

Comments
 (0)