Skip to content

Commit d1ae747

Browse files
committed
fix: Corrected bug where .replace() was treated as an in-place method
Signed-off-by: Varsha GS <[email protected]>
1 parent 45000ea commit d1ae747

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ jobs:
220220
requirements: "tests/requirements-gevent-starlette.txt"
221221
- run-tests-with-coverage-report:
222222
gevent: "true"
223-
tests: "tests/frameworks/test_gevent.py tests/frameworks/test_starlette.py"
223+
tests: "tests/frameworks/test_starlette.py tests/frameworks/test_gevent.py"
224224
- store-pytest-results
225225
- store-coverage-report
226226

src/instana/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def key_to_bool(k: str) -> bool:
8383
import inspect
8484

8585
all_accepted_patch_all_args = inspect.getfullargspec(monkey.patch_all)[0]
86-
provided_options.replace(" ", "").replace("--", "").split(",")
86+
provided_options = provided_options.replace(" ", "").replace("--", "").split(",")
8787

8888
provided_options = [
8989
k for k in provided_options if short_key(k) in all_accepted_patch_all_args

tests/conftest.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
collect_ignore_glob = [
2929
"*collector/test_gcr*",
3030
"*agent/test_google*",
31+
"*test_gevent_autotrace*"
3132
]
3233

3334
# ppc64le and s390x have limitations with some supported libraries.
@@ -53,7 +54,7 @@
5354
if not os.environ.get("GEVENT_STARLETTE_TEST"):
5455
collect_ignore_glob.extend(
5556
[
56-
"*test_gevent*",
57+
"*test_gevent.py",
5758
"*test_starlette*",
5859
]
5960
)

tests/frameworks/test_starlette.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ def _resource(self) -> Generator[None, None, None]:
2929
# Clear all spans before a test run.
3030
self.recorder = tracer.span_processor
3131
self.recorder.clear_spans()
32-
yield
3332

3433
def test_vanilla_get(self) -> None:
3534
result = self.client.get("/")

0 commit comments

Comments
 (0)