Skip to content

Commit df7c9e8

Browse files
committed
refactor(cassandra_inst): Reduce cyclomatic complexity with early return
Signed-off-by: Ferenc Géczi <[email protected]>
1 parent 15c80e0 commit df7c9e8

File tree

1 file changed

+20
-18
lines changed

1 file changed

+20
-18
lines changed

instana/instrumentation/cassandra_inst.py

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -54,24 +54,26 @@ def cb_request_error(results, span, fn):
5454
def request_init_with_instana(fn):
5555
active_tracer = get_active_tracer()
5656

57-
if active_tracer is not None:
58-
parent_span = active_tracer.active_span
59-
ctags = dict()
60-
if isinstance(fn.query, cassandra.query.SimpleStatement):
61-
ctags["cassandra.query"] = fn.query.query_string
62-
elif isinstance(fn.query, cassandra.query.BoundStatement):
63-
ctags["cassandra.query"] = fn.query.prepared_statement.query_string
64-
65-
ctags["cassandra.keyspace"] = fn.session.keyspace
66-
ctags["cassandra.cluster"] = fn.session.cluster.metadata.cluster_name
67-
68-
span = active_tracer.start_span(
69-
operation_name="cassandra",
70-
child_of=parent_span,
71-
tags=ctags)
72-
73-
fn.add_callback(cb_request_finish, span, fn)
74-
fn.add_errback(cb_request_error, span, fn)
57+
if active_tracer is None:
58+
return
59+
60+
parent_span = active_tracer.active_span
61+
ctags = dict()
62+
if isinstance(fn.query, cassandra.query.SimpleStatement):
63+
ctags["cassandra.query"] = fn.query.query_string
64+
elif isinstance(fn.query, cassandra.query.BoundStatement):
65+
ctags["cassandra.query"] = fn.query.prepared_statement.query_string
66+
67+
ctags["cassandra.keyspace"] = fn.session.keyspace
68+
ctags["cassandra.cluster"] = fn.session.cluster.metadata.cluster_name
69+
70+
span = active_tracer.start_span(
71+
operation_name="cassandra",
72+
child_of=parent_span,
73+
tags=ctags)
74+
75+
fn.add_callback(cb_request_finish, span, fn)
76+
fn.add_errback(cb_request_error, span, fn)
7577

7678

7779
@wrapt.patch_function_wrapper('cassandra.cluster', 'Session.__init__')

0 commit comments

Comments
 (0)