Update aiohttp client errors (#148)

Author: pglombardo

instana/instrumentation/aiohttp/client.py

@@ -41,7 +41,7 @@ async def stan_request_end(session, trace_config_ctx, params):
             if scope is not None:
                 scope.span.set_tag('http.status_code', params.response.status)
 
-                if 400 <= params.response.status <= 599:
+                if 500 <= params.response.status <= 599:
                     scope.span.set_tag("http.error", params.response.reason)
                     scope.span.set_tag("error", True)
                     ec = scope.span.tags.get('ec', 0)

tests/test_aiohttp.py

@@ -165,16 +165,15 @@ async def test():
         # Error logging
         self.assertFalse(test_span.error)
         self.assertIsNone(test_span.ec)
-        self.assertTrue(aiohttp_span.error)
-        self.assertEqual(aiohttp_span.ec, 1)
+        self.assertFalse(aiohttp_span.error)
+        self.assertIsNone(aiohttp_span.ec)
         self.assertIsNone(wsgi_span.error)
         self.assertIsNone(wsgi_span.ec)
 
         self.assertEqual("aiohttp-client", aiohttp_span.n)
         self.assertEqual(405, aiohttp_span.data.http.status)
         self.assertEqual("http://127.0.0.1:5000/405", aiohttp_span.data.http.url)
         self.assertEqual("GET", aiohttp_span.data.http.method)
-        self.assertEqual('METHOD NOT ALLOWED', aiohttp_span.data.http.error)
         self.assertIsNotNone(aiohttp_span.stack)
         self.assertTrue(type(aiohttp_span.stack) is list)
         self.assertTrue(len(aiohttp_span.stack) > 1)
@@ -613,8 +612,8 @@ async def test():
         # Error logging
         self.assertFalse(test_span.error)
         self.assertIsNone(test_span.ec)
-        self.assertTrue(aioclient_span.error)
-        self.assertEqual(aioclient_span.ec, 1)
+        self.assertFalse(aioclient_span.error)
+        self.assertIsNone(aioclient_span.ec)
         self.assertFalse(aioserver_span.error)
         self.assertIsNone(aioserver_span.ec)
 
@@ -630,7 +629,6 @@ async def test():
         self.assertEqual(401, aioclient_span.data.http.status)
         self.assertEqual("http://127.0.0.1:5002/401", aioclient_span.data.http.url)
         self.assertEqual("GET", aioclient_span.data.http.method)
-        self.assertEqual('I must simulate errors.', aioclient_span.data.http.error)
         self.assertIsNotNone(aioclient_span.stack)
         self.assertTrue(type(aioclient_span.stack) is list)
         self.assertTrue(len(aioclient_span.stack) > 1)