Commit e655099
authored
fix(requirements-asynqp): Update flask to latest stable (#347)
* fix(requirements-asynqp): Update flask to latest stable
* This issue is described in
pallets/markupsafe#284
* The recommended action is to upgrade Jinja2,
pallets/markupsafe#284 (comment)
but that only works with newer flask, so hence the flask upgrade.
* The exact backtrace in our case, that we are trying to avoid here is this:
```
Traceback:
/usr/local/lib/python3.7/importlib/__init__.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
tests/clients/test_asynqp.py:16: in <module>
import tests.apps.flask_app
tests/apps/flask_app/__init__.py:5: in <module>
from .app import flask_server as server
tests/apps/flask_app/app.py:10: in <module>
from flask import jsonify, Response
venv/lib/python3.7/site-packages/flask/__init__.py:14: in <module>
from jinja2 import escape
venv/lib/python3.7/site-packages/jinja2/__init__.py:12: in <module>
from .environment import Environment
venv/lib/python3.7/site-packages/jinja2/environment.py:25: in <module>
from .defaults import BLOCK_END_STRING
venv/lib/python3.7/site-packages/jinja2/defaults.py:3: in <module>
from .filters import FILTERS as DEFAULT_FILTERS # noqa: F401
venv/lib/python3.7/site-packages/jinja2/filters.py:13: in <module>
from markupsafe import soft_unicode
E ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/circleci/repo/venv/lib/python3.7/site-packages/markupsafe/__init__.py)
```
* feat(ci): Add test job for legacy flask/Jinja2/markupsafe versions1 parent 5a822b6 commit e655099
File tree
3 files changed
+39
-2
lines changed- .circleci
- tests
3 files changed
+39
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
255 | 255 | | |
256 | 256 | | |
257 | 257 | | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
258 | 278 | | |
259 | 279 | | |
260 | 280 | | |
| |||
283 | 303 | | |
284 | 304 | | |
285 | 305 | | |
| 306 | + | |
286 | 307 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
0 commit comments