fix(ci): Arguments sequence to send Slack announcement.

Signed-off-by: Paulo Vital <[email protected]>

Author: pvital

.github/scripts/announce_pr_on_slack.py

@@ -25,22 +25,20 @@ def send_slack_message(
 
     data = {"text": message}
 
-    try:
-        with httpx.Client() as client:
-            response = client.post(url, headers=headers, json=data)
-            response.raise_for_status()
+    ret = False
+    with httpx.Client() as client:
+        response = client.post(url, headers=headers, json=data)
+        response.raise_for_status()
 
-            result = response.text
-            if "ok" in result:
-                print("✅ Slack message sent successfully")
-                return True
-            else:
-                print(f"❌ Slack API error: {result}")
-                return False
+        result = response.text
+        if "ok" in result:
+            print("✅ Slack message sent successfully")
+            ret = True
+        else:
+            print(f"❌ Slack API error: {result}")
+            ret = False
 
-    except httpx.HTTPError as e:
-        print(f"❌ Request error: {e}")
-        return False
+    return ret
 
 
 def ensure_environment_variables_are_present() -> (
@@ -139,7 +137,7 @@ def main() -> None:
     )
 
     # Send to Slack
-    success = send_slack_message(slack_service, slack_team, slack_token, message)
+    success = send_slack_message(slack_team, slack_service, slack_token, message)
 
     if not success:
         sys.exit(1)

.github/workflows/opened-pr-notification-on-slack.yml

@@ -6,7 +6,7 @@ permissions:
 
 on:
   pull_request:
-    types: [opened, reopened, review_requested]
+    types: [opened, reopened]
 
 jobs:
   notify-slack: