fix(lambda): Record the statusCode when available

Signed-off-by: Ferenc Géczi <[email protected]>

Author: Ferenc-

instana/instrumentation/aws/lambda_inst.py

@@ -6,6 +6,7 @@
 """
 import sys
 import wrapt
+import opentracing.ext.tags as ext
 
 from ...log import logger
 from ...singletons import env_is_aws_lambda
@@ -35,6 +36,8 @@ def lambda_handler_with_instana(wrapped, instance, args, kwargs):
                     result['headers']['Server-Timing'] = server_timing_value
                 elif 'multiValueHeaders' in result:
                     result['multiValueHeaders']['Server-Timing'] = [server_timing_value]
+                if 'statusCode' in result:
+                    scope.span.set_tag(ext.HTTP_STATUS_CODE, int(result['statusCode']))
         except Exception as exc:
             if scope.span:
                 exc = traceback.format_exc()

tests/platforms/test_lambda.py

@@ -230,6 +230,7 @@ def test_custom_service_name(self):
 
         self.assertEqual('aws:api.gateway', span.data['lambda']['trigger'])
         self.assertEqual('POST', span.data['http']['method'])
+        self.assertEqual(200, span.data['http']['status'])
         self.assertEqual('/path/to/resource', span.data['http']['url'])
         self.assertEqual('/{proxy+}', span.data['http']['path_tpl'])
         self.assertEqual("foo=['bar']", span.data['http']['params'])
@@ -293,6 +294,7 @@ def test_api_gateway_trigger_tracing(self):
 
         self.assertEqual('aws:api.gateway', span.data['lambda']['trigger'])
         self.assertEqual('POST', span.data['http']['method'])
+        self.assertEqual(200, span.data['http']['status'])
         self.assertEqual('/path/to/resource', span.data['http']['url'])
         self.assertEqual('/{proxy+}', span.data['http']['path_tpl'])
         self.assertEqual("foo=['bar']", span.data['http']['params'])
@@ -356,6 +358,7 @@ def test_api_gateway_v2_trigger_tracing(self):
 
         self.assertEqual('aws:api.gateway', span.data['lambda']['trigger'])
         self.assertEqual('POST', span.data['http']['method'])
+        self.assertEqual(200, span.data['http']['status'])
         self.assertEqual('/my/path', span.data['http']['url'])
         self.assertEqual('/my/{resource}', span.data['http']['path_tpl'])
         self.assertEqual("secret=key&q=term", span.data['http']['params'])
@@ -420,6 +423,7 @@ def test_application_lb_trigger_tracing(self):
 
         self.assertEqual('aws:api.gateway', span.data['lambda']['trigger'])
         self.assertEqual('POST', span.data['http']['method'])
+        self.assertEqual(200, span.data['http']['status'])
         self.assertEqual('/path/to/resource', span.data['http']['url'])
         self.assertEqual("foo=['bar']", span.data['http']['params'])