Skip to content

Commit fa26ce0

Browse files
authored
fix(service): fix the wrong object size (#222)
Because - the object metadata was not correct when returning the object download link. This commit - fixes the wrong object metadata.
1 parent 25b8b41 commit fa26ce0

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

pkg/minio/minio.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ type MinioI interface {
3333
GetFile(ctx context.Context, bucket string, filePath string) ([]byte, error)
3434
// GetFilesByPaths
3535
GetFilesByPaths(ctx context.Context, bucket string, filePaths []string) ([]FileContent, error)
36+
// GetFileMetadata: get the metadata of the file
37+
GetFileMetadata(ctx context.Context, bucket string, filePath string) (*minio.ObjectInfo, error)
3638
// KnowledgeBase
3739
KnowledgeBaseI
3840
// Object
@@ -219,6 +221,14 @@ func (m *Minio) GetFile(ctx context.Context, bucket string, filePathName string)
219221
return buf.Bytes(), nil
220222
}
221223

224+
func (m *Minio) GetFileMetadata(ctx context.Context, bucket string, filePathName string) (*minio.ObjectInfo, error) {
225+
object, err := m.client.StatObject(ctx, bucket, filePathName, minio.StatObjectOptions{})
226+
if err != nil {
227+
return nil, err
228+
}
229+
return &object, nil
230+
}
231+
222232
// FileContent represents a file and its content
223233
type FileContent struct {
224234
Index int

pkg/service/object.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,13 +156,15 @@ func (s *service) GetDownloadURL(
156156
return nil, ErrObjectNotUploaded
157157
}
158158

159-
_, err := s.minIO.GetFile(ctx, miniolocal.BlobBucketName, object.Destination)
159+
objectInfo, err := s.minIO.GetFileMetadata(ctx, miniolocal.BlobBucketName, object.Destination)
160160
if err != nil {
161161
log.Error("failed to get file", zap.Error(err))
162162
return nil, status.Errorf(codes.Internal, "failed to get file: %v", err)
163163
}
164164
object.IsUploaded = true
165-
165+
object.Size = objectInfo.Size
166+
object.LastModifiedTime = &objectInfo.LastModified
167+
object.ContentType = objectInfo.ContentType
166168
}
167169

168170
// Check URL expiration days

0 commit comments

Comments
 (0)