Skip to content

Commit 01ac0b7

Browse files
pinglinpinglin
committed
fix(helm): ensure image tags are rendered as strings to avoid scientific notation
When image tags are pure numeric commit hashes (e.g., 5674282), YAML parses them as numbers. Go templates can then render large numbers in scientific notation (5.674282e+06), causing invalid Docker image references. This fix adds `| toString` to all image tag template interpolations across all deployment templates.
1 parent 38a5712 commit 01ac0b7

File tree

7 files changed

+26
-26
lines changed

7 files changed

+26
-26
lines changed

‎charts/core/templates/api-gateway/deployment.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ spec:
7575
{{- end }}
7676
containers:
7777
- name: api-gateway
78-
image: {{ .Values.apiGateway.image.repository }}:{{ .Values.apiGateway.image.tag }}
78+
image: {{ .Values.apiGateway.image.repository }}:{{ .Values.apiGateway.image.tag | toString }}
7979
imagePullPolicy: {{ .Values.apiGateway.image.pullPolicy }}
8080
readinessProbe:
8181
httpGet:

‎charts/core/templates/artifact-backend/deployment.yaml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ spec:
5757
{{- end }}
5858
{{- if .Values.database.enabled }}
5959
- name: wait-for-db
60-
image: {{ .Values.database.image.repository }}:{{ .Values.database.image.tag }}
60+
image: {{ .Values.database.image.repository }}:{{ .Values.database.image.tag | toString }}
6161
imagePullPolicy: {{ $.Values.database.image.pullPolicy }}
6262
command: ['sh', '-c', "until pg_isready; do echo waiting for db; sleep 2; done"]
6363
env:
@@ -67,7 +67,7 @@ spec:
6767
value: {{ include "core.database.username" . }}
6868
{{- end }}
6969
- name: artifact-backend-migration
70-
image: {{ .Values.artifactBackend.image.repository }}:{{ .Values.artifactBackend.image.tag }}
70+
image: {{ .Values.artifactBackend.image.repository }}:{{ .Values.artifactBackend.image.tag | toString }}
7171
imagePullPolicy: {{ .Values.artifactBackend.image.pullPolicy }}
7272
{{- if .Values.artifactBackend.resources }}
7373
resources:
@@ -94,7 +94,7 @@ spec:
9494
- name: PIPELINE_BACKEND_PORT
9595
value: "{{ include "core.pipelineBackend.publicPort" . }}"
9696
- name: artifact-backend-init
97-
image: {{ .Values.artifactBackend.image.repository }}:{{ .Values.artifactBackend.image.tag }}
97+
image: {{ .Values.artifactBackend.image.repository }}:{{ .Values.artifactBackend.image.tag | toString }}
9898
imagePullPolicy: {{ .Values.artifactBackend.image.pullPolicy }}
9999
command: [./{{ .Values.artifactBackend.commandName.init }}]
100100
volumeMounts:
@@ -110,7 +110,7 @@ spec:
110110
{{- end }}
111111
containers:
112112
- name: artifact-backend
113-
image: {{ .Values.artifactBackend.image.repository }}:{{ .Values.artifactBackend.image.tag }}
113+
image: {{ .Values.artifactBackend.image.repository }}:{{ .Values.artifactBackend.image.tag | toString }}
114114
imagePullPolicy: {{ .Values.artifactBackend.image.pullPolicy }}
115115
readinessProbe:
116116
httpGet:
@@ -242,7 +242,7 @@ spec:
242242
{{- end }}
243243
{{- if .Values.database.enabled }}
244244
- name: wait-for-db
245-
image: {{ .Values.database.image.repository }}:{{ .Values.database.image.tag }}
245+
image: {{ .Values.database.image.repository }}:{{ .Values.database.image.tag | toString }}
246246
imagePullPolicy: {{ $.Values.database.image.pullPolicy }}
247247
command: ['sh', '-c', "until pg_isready; do echo waiting for db; sleep 2; done"]
248248
env:
@@ -267,7 +267,7 @@ spec:
267267
{{- end }}
268268
containers:
269269
- name: artifact-backend-worker
270-
image: {{ .Values.artifactBackend.image.repository }}:{{ .Values.artifactBackend.image.tag }}
270+
image: {{ .Values.artifactBackend.image.repository }}:{{ .Values.artifactBackend.image.tag | toString }}
271271
imagePullPolicy: {{ .Values.artifactBackend.image.pullPolicy }}
272272
livenessProbe:
273273
tcpSocket:

‎charts/core/templates/console/deployment.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ spec:
5454
{{- end }}
5555
containers:
5656
- name: console
57-
image: {{ .Values.console.image.repository }}:{{ .Values.console.image.tag }}
57+
image: {{ .Values.console.image.repository }}:{{ .Values.console.image.tag | toString }}
5858
imagePullPolicy: {{ .Values.console.image.pullPolicy }}
5959
readinessProbe:
6060
httpGet:

‎charts/core/templates/mgmt-backend/deployment.yaml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ spec:
5757
{{- end }}
5858
{{- if .Values.database.enabled }}
5959
- name: wait-for-db
60-
image: {{ .Values.database.image.repository }}:{{ .Values.database.image.tag }}
60+
image: {{ .Values.database.image.repository }}:{{ .Values.database.image.tag | toString }}
6161
imagePullPolicy: {{ $.Values.database.image.pullPolicy }}
6262
command: ['sh', '-c', "until pg_isready; do echo waiting for db; sleep 2; done"]
6363
env:
@@ -83,7 +83,7 @@ spec:
8383
{{- end }}
8484
{{- if .Values.isPrimaryCluster }}
8585
- name: mgmt-backend-migration
86-
image: {{ .Values.mgmtBackend.image.repository }}:{{ .Values.mgmtBackend.image.tag }}
86+
image: {{ .Values.mgmtBackend.image.repository }}:{{ .Values.mgmtBackend.image.tag | toString }}
8787
imagePullPolicy: {{ .Values.mgmtBackend.image.pullPolicy }}
8888
{{- if .Values.mgmtBackend.resources }}
8989
resources:
@@ -103,7 +103,7 @@ spec:
103103
{{- end }}
104104
{{- end }}
105105
- name: mgmt-backend-init
106-
image: {{ .Values.mgmtBackend.image.repository }}:{{ .Values.mgmtBackend.image.tag }}
106+
image: {{ .Values.mgmtBackend.image.repository }}:{{ .Values.mgmtBackend.image.tag | toString }}
107107
imagePullPolicy: {{ .Values.mgmtBackend.image.pullPolicy }}
108108
{{- if .Values.mgmtBackend.resources }}
109109
resources:
@@ -126,7 +126,7 @@ spec:
126126
{{- end }}
127127
containers:
128128
- name: mgmt-backend
129-
image: {{ .Values.mgmtBackend.image.repository }}:{{ .Values.mgmtBackend.image.tag }}
129+
image: {{ .Values.mgmtBackend.image.repository }}:{{ .Values.mgmtBackend.image.tag | toString }}
130130
imagePullPolicy: {{ .Values.mgmtBackend.image.pullPolicy }}
131131
readinessProbe:
132132
httpGet:
@@ -172,7 +172,7 @@ spec:
172172
{{- toYaml . | nindent 12 }}
173173
{{- end }}
174174
- name: mgmt-backend-worker
175-
image: {{ .Values.mgmtBackend.image.repository }}:{{ .Values.mgmtBackend.image.tag }}
175+
image: {{ .Values.mgmtBackend.image.repository }}:{{ .Values.mgmtBackend.image.tag | toString }}
176176
imagePullPolicy: {{ .Values.mgmtBackend.image.pullPolicy }}
177177
livenessProbe:
178178
tcpSocket:

‎charts/core/templates/model-backend/deployment.yaml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ spec:
5757
{{- end }}
5858
{{- if .Values.database.enabled }}
5959
- name: wait-for-db
60-
image: {{ .Values.database.image.repository }}:{{ .Values.database.image.tag }}
60+
image: {{ .Values.database.image.repository }}:{{ .Values.database.image.tag | toString }}
6161
imagePullPolicy: {{ $.Values.database.image.pullPolicy }}
6262
command: ['sh', '-c', "until pg_isready; do echo waiting for db; sleep 2; done"]
6363
env:
@@ -81,7 +81,7 @@ spec:
8181
value: "{{ include "temporal.host" . }}:{{ include "temporal.frontend.grpcPort" . }}"
8282
{{- end }}
8383
- name: model-backend-migration
84-
image: {{ .Values.modelBackend.image.repository }}:{{ .Values.modelBackend.image.tag }}
84+
image: {{ .Values.modelBackend.image.repository }}:{{ .Values.modelBackend.image.tag | toString }}
8585
imagePullPolicy: {{ .Values.modelBackend.image.pullPolicy }}
8686
{{- if .Values.modelBackend.resources }}
8787
resources:
@@ -97,7 +97,7 @@ spec:
9797
{{- toYaml .Values.modelBackend.extraEnv | nindent 12 }}
9898
{{- end }}
9999
- name: model-backend-init
100-
image: {{ .Values.modelBackend.image.repository }}:{{ .Values.modelBackend.image.tag }}
100+
image: {{ .Values.modelBackend.image.repository }}:{{ .Values.modelBackend.image.tag | toString }}
101101
imagePullPolicy: {{ .Values.modelBackend.image.pullPolicy }}
102102
{{- if .Values.modelBackend.resources }}
103103
resources:
@@ -128,7 +128,7 @@ spec:
128128
{{- end }}
129129
containers:
130130
- name: model-backend-worker
131-
image: {{ .Values.modelBackend.image.repository }}:{{ .Values.modelBackend.image.tag }}
131+
image: {{ .Values.modelBackend.image.repository }}:{{ .Values.modelBackend.image.tag | toString }}
132132
imagePullPolicy: {{ .Values.modelBackend.image.pullPolicy }}
133133
livenessProbe:
134134
tcpSocket:
@@ -150,7 +150,7 @@ spec:
150150
{{- toYaml .Values.modelBackend.extraEnv | nindent 12 }}
151151
{{- end }}
152152
- name: model-backend
153-
image: {{ .Values.modelBackend.image.repository }}:{{ .Values.modelBackend.image.tag }}
153+
image: {{ .Values.modelBackend.image.repository }}:{{ .Values.modelBackend.image.tag | toString }}
154154
imagePullPolicy: {{ .Values.modelBackend.image.pullPolicy }}
155155
readinessProbe:
156156
httpGet:

‎charts/core/templates/pipeline-backend/deployment.yaml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ spec:
5757
{{- end }}
5858
{{- if .Values.database.enabled }}
5959
- name: wait-for-db
60-
image: {{ .Values.database.image.repository }}:{{ .Values.database.image.tag }}
60+
image: {{ .Values.database.image.repository }}:{{ .Values.database.image.tag | toString }}
6161
imagePullPolicy: {{ $.Values.database.image.pullPolicy }}
6262
command: ['sh', '-c', "until pg_isready; do echo waiting for db; sleep 2; done"]
6363
env:
@@ -82,7 +82,7 @@ spec:
8282
value: "{{ include "temporal.host" . }}:{{ include "temporal.frontend.grpcPort" . }}"
8383
{{- end }}
8484
- name: pipeline-backend-migration
85-
image: {{ .Values.pipelineBackend.image.repository }}:{{ .Values.pipelineBackend.image.tag }}
85+
image: {{ .Values.pipelineBackend.image.repository }}:{{ .Values.pipelineBackend.image.tag | toString }}
8686
imagePullPolicy: {{ .Values.pipelineBackend.image.pullPolicy }}
8787
{{- if .Values.pipelineBackend.resources }}
8888
resources:
@@ -98,7 +98,7 @@ spec:
9898
{{- toYaml .Values.pipelineBackend.extraEnv | nindent 12 }}
9999
{{- end }}
100100
- name: pipeline-backend-init
101-
image: {{ .Values.pipelineBackend.image.repository }}:{{ .Values.pipelineBackend.image.tag }}
101+
image: {{ .Values.pipelineBackend.image.repository }}:{{ .Values.pipelineBackend.image.tag | toString }}
102102
imagePullPolicy: {{ .Values.pipelineBackend.image.pullPolicy }}
103103
{{- if .Values.pipelineBackend.resources }}
104104
resources:
@@ -136,7 +136,7 @@ spec:
136136
{{- end }}
137137
containers:
138138
- name: pipeline-backend
139-
image: {{ .Values.pipelineBackend.image.repository }}:{{ .Values.pipelineBackend.image.tag }}
139+
image: {{ .Values.pipelineBackend.image.repository }}:{{ .Values.pipelineBackend.image.tag | toString }}
140140
imagePullPolicy: {{ .Values.pipelineBackend.image.pullPolicy }}
141141
readinessProbe:
142142
httpGet:
@@ -264,7 +264,7 @@ spec:
264264
{{- end }}
265265
{{- if .Values.database.enabled }}
266266
- name: wait-for-db
267-
image: {{ .Values.database.image.repository }}:{{ .Values.database.image.tag }}
267+
image: {{ .Values.database.image.repository }}:{{ .Values.database.image.tag | toString }}
268268
imagePullPolicy: {{ $.Values.database.image.pullPolicy }}
269269
command: ['sh', '-c', "until pg_isready; do echo waiting for db; sleep 2; done"]
270270
env:
@@ -289,7 +289,7 @@ spec:
289289
{{- end }}
290290
containers:
291291
- name: pipeline-backend-worker
292-
image: {{ .Values.pipelineBackend.image.repository }}:{{ .Values.pipelineBackend.image.tag }}
292+
image: {{ .Values.pipelineBackend.image.repository }}:{{ .Values.pipelineBackend.image.tag | toString }}
293293
imagePullPolicy: {{ .Values.pipelineBackend.image.pullPolicy }}
294294
livenessProbe:
295295
tcpSocket:

‎charts/core/templates/registry/deployment.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ spec:
5252
{{- end }}
5353
initContainers:
5454
- name: wait-for-redis
55-
image: {{ .Values.redis.image.repository }}:{{ .Values.redis.image.tag }}
55+
image: {{ .Values.redis.image.repository }}:{{ .Values.redis.image.tag | toString }}
5656
command: ['sh', '-c']
5757
args:
5858
- >
@@ -65,7 +65,7 @@ spec:
6565
value: "{{ (split ":" .Values.registry.config.redis.addr)._0 }}"
6666
containers:
6767
- name: registry
68-
image: {{ .Values.registry.image.repository }}:{{ .Values.registry.image.tag }}
68+
image: {{ .Values.registry.image.repository }}:{{ .Values.registry.image.tag | toString }}
6969
imagePullPolicy: {{ .Values.registry.image.pullPolicy }}
7070
command:
7171
- /bin/registry

0 commit comments

Comments
 (0)