chore(model,connector,billing): rename list message struct with plural (#145)

Because

- follow [Google AIP 132](https://google.aip.dev/132), list message uses plural name

This commit

- update list message struct name

Author: phelan

openapiv2/openapiv2.swagger.yaml

@@ -75,8 +75,8 @@ enum View {
   VIEW_FULL = 2;
 }
 
-// ListPlanRequest represents a request to list all plans
-message ListPlanRequest {
+// ListPlansRequest represents a request to list all plans
+message ListPlansRequest {
   // Page size: the maximum number of resources to return. The service may
   // return fewer than this value. If unspecified, at most 10 plans will be
   // returned. The maximum value is 100; values above 100 will be coereced to
@@ -90,8 +90,8 @@ message ListPlanRequest {
   optional string filter = 4 [ (google.api.field_behavior) = OPTIONAL ];
 }
 
-// ListPlanResponse represents a response for a list of plans
-message ListPlanResponse {
+// ListPlansResponse represents a response for a list of plans
+message ListPlansResponse {
   // A list of plans
   repeated Plan plans = 1;
   // Next page token

vdp/billing/v1alpha/plan.proto

@@ -35,9 +35,9 @@ service PlanService {
 
   // ========== Admin API: create, get, update and delete billing plans
 
-  // ListPlan method receives a ListPlanRequest message and returns a
-  // ListPlanResponse message.
-  rpc ListPlan(ListPlanRequest) returns (ListPlanResponse) {
+  // ListPlans method receives a ListPlansRequest message and returns a
+  // ListPlansResponse message.
+  rpc ListPlans(ListPlansRequest) returns (ListPlansResponse) {
     option (google.api.http) = {
       get : "/v1alpha/admin/plans"
     };

vdp/billing/v1alpha/plan_service.proto

@@ -138,9 +138,9 @@ message CreateSourceConnectorResponse {
   SourceConnector source_connector = 1;
 }
 
-// ListSourceConnectorRequest represents a request to list
+// ListSourceConnectorsRequest represents a request to list
 // SourceConnector resources
-message ListSourceConnectorRequest {
+message ListSourceConnectorsRequest {
   // The maximum number of connectors to return. The service may return fewer
   // than this value. If unspecified, at most 10 connectors will be returned.
   // The maximum value is 100; values above 100 will be coerced to 100.
@@ -151,9 +151,9 @@ message ListSourceConnectorRequest {
   optional View view = 3 [ (google.api.field_behavior) = OPTIONAL ];
 }
 
-// ListSourceConnectorResponse represents a response for a list of
+// ListSourceConnectorsResponse represents a response for a list of
 // SourceConnector resources
-message ListSourceConnectorResponse {
+message ListSourceConnectorsResponse {
   // A list of SourceConnector resources
   repeated SourceConnector source_connectors = 1;
   // Next page token
@@ -338,9 +338,9 @@ message CreateDestinationConnectorResponse {
   DestinationConnector destination_connector = 1;
 }
 
-// ListDestinationConnectorRequest represents a request to list
+// ListDestinationConnectorsRequest represents a request to list
 // DestinationConnector resources
-message ListDestinationConnectorRequest {
+message ListDestinationConnectorsRequest {
   // The maximum number of connectors to return. The service may return fewer
   // than this value. If unspecified, at most 10 connectors will be returned.
   // The maximum value is 100; values above 100 will be coerced to 100.
@@ -351,9 +351,9 @@ message ListDestinationConnectorRequest {
   optional View view = 3 [ (google.api.field_behavior) = OPTIONAL ];
 }
 
-// ListDestinationConnectorResponse represents a response for a list of
+// ListDestinationConnectorsResponse represents a response for a list of
 // DestinationConnector resources
-message ListDestinationConnectorResponse {
+message ListDestinationConnectorsResponse {
   // A list of DestinationConnector resources
   repeated DestinationConnector destination_connectors = 1;
   // Next page token
@@ -545,9 +545,9 @@ message WriteDestinationConnectorResponse {}
 
 // ========== Admin endpoints
 
-// ListSourceConnectorAdminRequest represents a request to list
+// ListSourceConnectorsAdminRequest represents a request to list
 // SourceConnector resources from all users by admin
-message ListSourceConnectorAdminRequest {
+message ListSourceConnectorsAdminRequest {
   // The maximum number of connectors to return. The service may return fewer
   // than this value. If unspecified, at most 10 connectors will be returned.
   // The maximum value is 100; values above 100 will be coerced to 100.
@@ -558,9 +558,9 @@ message ListSourceConnectorAdminRequest {
   optional View view = 3 [ (google.api.field_behavior) = OPTIONAL ];
 }
 
-// ListSourceConnectorAdminResponse represents a response for a list of
+// ListSourceConnectorsAdminResponse represents a response for a list of
 // SourceConnector resources
-message ListSourceConnectorAdminResponse {
+message ListSourceConnectorsAdminResponse {
   // A list of SourceConnector resources
   repeated SourceConnector source_connectors = 1;
   // Next page token
@@ -610,9 +610,9 @@ message LookUpSourceConnectorAdminResponse {
   SourceConnector source_connector = 1;
 }
 
-// ListDestinationConnectorAdminRequest represents a request to list
+// ListDestinationConnectorsAdminRequest represents a request to list
 // DestinationConnector resources from all users by admin
-message ListDestinationConnectorAdminRequest {
+message ListDestinationConnectorsAdminRequest {
   // The maximum number of connectors to return. The service may return fewer
   // than this value. If unspecified, at most 10 connectors will be returned.
   // The maximum value is 100; values above 100 will be coerced to 100.
@@ -623,9 +623,9 @@ message ListDestinationConnectorAdminRequest {
   optional View view = 3 [ (google.api.field_behavior) = OPTIONAL ];
 }
 
-// ListDestinationConnectorAdminResponse represents a response for a list of
+// ListDestinationConnectorsAdminResponse represents a response for a list of
 // DestinationConnector resources
-message ListDestinationConnectorAdminResponse {
+message ListDestinationConnectorsAdminResponse {
   // A list of DestinationConnector resources
   repeated DestinationConnector destination_connectors = 1;
   // Next page token

vdp/connector/v1alpha/connector.proto

@@ -154,9 +154,9 @@ message DestinationConnectorDefinition {
 
 //  SourceConnectorDefinition
 //
-// ListSourceConnectorDefinitionRequest represents a request to list
+// ListSourceConnectorDefinitionsRequest represents a request to list
 // SourceConnectorDefinitions
-message ListSourceConnectorDefinitionRequest {
+message ListSourceConnectorDefinitionsRequest {
   // The maximum number of SourceConnectorDefinitions to return. The service may
   // return fewer than this value. If unspecified, at most 10
   // SourceConnectorDefinitions will be returned. The maximum value is 100;
@@ -168,9 +168,9 @@ message ListSourceConnectorDefinitionRequest {
   optional View view = 3 [ (google.api.field_behavior) = OPTIONAL ];
 }
 
-// ListSourceConnectorDefinitionResponse represents a response for a list of
+// ListSourceConnectorDefinitionsResponse represents a response for a list of
 // SourceConnectorDefinitions
-message ListSourceConnectorDefinitionResponse {
+message ListSourceConnectorDefinitionsResponse {
   // A list of SourceConnectorDefinition resources
   repeated SourceConnectorDefinition source_connector_definitions = 1;
   // Next page token
@@ -209,9 +209,9 @@ message GetSourceConnectorDefinitionResponse {
 ///////////////////////////////////////////////////////////////////////
 //  DestinationConnectorDefinition
 //
-// ListDestinationConnectorDefinitionRequest represents a request to list
+// ListDestinationConnectorDefinitionsRequest represents a request to list
 // DestinationConnectorDefinitions
-message ListDestinationConnectorDefinitionRequest {
+message ListDestinationConnectorDefinitionsRequest {
   // The maximum number of DestinationConnectorDefinitions to return. The
   // service may return fewer than this value. If unspecified, at most 10
   // DestinationConnectorDefinitions will be returned. The maximum value is 100;
@@ -223,9 +223,9 @@ message ListDestinationConnectorDefinitionRequest {
   optional View view = 3 [ (google.api.field_behavior) = OPTIONAL ];
 }
 
-// ListDestinationConnectorDefinitionResponse represents a response for a list
+// ListDestinationConnectorDefinitionsResponse represents a response for a list
 // of DestinationConnectorDefinitions
-message ListDestinationConnectorDefinitionResponse {
+message ListDestinationConnectorDefinitionsResponse {
   // A list of DestinationConnectorDefinition resources
   repeated DestinationConnectorDefinition destination_connector_definitions = 1;
   // Next page token

vdp/connector/v1alpha/connector_definition.proto

@@ -13,10 +13,10 @@ service ConnectorPrivateService {
 
   // *SourceConnector methods
 
-  // ListSourceConnectorAdmin method receives a ListSourceConnectorAdminRequest
-  // message and returns a ListSourceConnectorAdminResponse message.
-  rpc ListSourceConnectorAdmin(ListSourceConnectorAdminRequest)
-      returns (ListSourceConnectorAdminResponse) {
+  // ListSourceConnectorsAdmin method receives a ListSourceConnectorsAdminRequest message
+  // and returns a ListSourceConnectorsAdminResponse message.
+  rpc ListSourceConnectorsAdmin(ListSourceConnectorsAdminRequest)
+      returns (ListSourceConnectorsAdminResponse) {
     option (google.api.http) = {
       get : "/v1alpha/admin/source-connectors"
     };
@@ -45,11 +45,10 @@ service ConnectorPrivateService {
 
   // *DestinationConnector methods
 
-  // ListDestinationConnectorAdmin method receives a
-  // ListDestinationConnectorAdminRequest message and returns a
-  // ListDestinationConnectorResponse message.
-  rpc ListDestinationConnectorAdmin(ListDestinationConnectorAdminRequest)
-      returns (ListDestinationConnectorAdminResponse) {
+  // ListDestinationConnectorsAdmin method receives a ListDestinationConnectorsAdminRequest
+  // message and returns a ListDestinationConnectorsResponse message.
+  rpc ListDestinationConnectorsAdmin(ListDestinationConnectorsAdminRequest)
+      returns (ListDestinationConnectorsAdminResponse) {
     option (google.api.http) = {
       get : "/v1alpha/admin/destination-connectors"
     };

vdp/connector/v1alpha/connector_private_service.proto

@@ -37,11 +37,11 @@ service ConnectorPublicService {
     };
   }
 
-  // ListSourceConnectorDefinition method receives a
-  // ListSourceConnectorDefinitionRequest message and returns a
-  // ListSourceConnectorDefinitionResponse message.
-  rpc ListSourceConnectorDefinition(ListSourceConnectorDefinitionRequest)
-      returns (ListSourceConnectorDefinitionResponse) {
+  // ListSourceConnectorDefinitions method receives a
+  // ListSourceConnectorDefinitionsRequest message and returns a
+  // ListSourceConnectorDefinitionsResponse message.
+  rpc ListSourceConnectorDefinitions(ListSourceConnectorDefinitionsRequest)
+      returns (ListSourceConnectorDefinitionsResponse) {
     option (google.api.http) = {
       get : "/v1alpha/source-connector-definitions"
     };
@@ -58,12 +58,12 @@ service ConnectorPublicService {
     option (google.api.method_signature) = "name";
   }
 
-  // ListDestinationConnectorDefinition method receives a
-  // ListDestinationConnectorDefinitionRequest message and returns a
-  // ListDestinationConnectorDefinitionResponse message.
-  rpc ListDestinationConnectorDefinition(
-      ListDestinationConnectorDefinitionRequest)
-      returns (ListDestinationConnectorDefinitionResponse) {
+  // ListDestinationConnectorDefinitions method receives a
+  // ListDestinationConnectorDefinitionsRequest message and returns a
+  // ListDestinationConnectorDefinitionsResponse message.
+  rpc ListDestinationConnectorDefinitions(
+      ListDestinationConnectorDefinitionsRequest)
+      returns (ListDestinationConnectorDefinitionsResponse) {
     option (google.api.http) = {
       get : "/v1alpha/destination-connector-definitions"
     };
@@ -98,10 +98,10 @@ service ConnectorPublicService {
     option (google.api.method_signature) = "source_connector";
   }
 
-  // ListSourceConnector method receives a ListSourceConnectorRequest message
-  // and returns a ListSourceConnectorResponse message.
-  rpc ListSourceConnector(ListSourceConnectorRequest)
-      returns (ListSourceConnectorResponse) {
+  // ListSourceConnectors method receives a ListSourceConnectorsRequest message
+  // and returns a ListSourceConnectorsResponse message.
+  rpc ListSourceConnectors(ListSourceConnectorsRequest)
+      returns (ListSourceConnectorsResponse) {
     option (google.api.http) = {
       get : "/v1alpha/source-connectors"
     };
@@ -212,10 +212,10 @@ service ConnectorPublicService {
     option (google.api.method_signature) = "destination_connector";
   }
 
-  // ListDestinationConnector method receives a ListDestinationConnectorRequest
-  // message and returns a ListDestinationConnectorResponse message.
-  rpc ListDestinationConnector(ListDestinationConnectorRequest)
-      returns (ListDestinationConnectorResponse) {
+  // ListDestinationConnectors method receives a ListDestinationConnectorsRequest
+  // message and returns a ListDestinationConnectorsResponse message.
+  rpc ListDestinationConnectors(ListDestinationConnectorsRequest)
+      returns (ListDestinationConnectorsResponse) {
     option (google.api.http) = {
       get : "/v1alpha/destination-connectors"
     };

vdp/connector/v1alpha/connector_public_service.proto

@@ -179,8 +179,8 @@ message ModelInstanceCard {
   string encoding = 5 [ (google.api.field_behavior) = OUTPUT_ONLY ];
 }
 
-// ListModelRequest represents a request to list all models
-message ListModelRequest {
+// ListModelsRequest represents a request to list all models
+message ListModelsRequest {
   // Page size: the maximum number of resources to return. The service may
   // return fewer than this value. If unspecified, at most 10 models will be
   // returned. The maximum value is 100; values above 100 will be coereced to
@@ -194,8 +194,8 @@ message ListModelRequest {
   optional View view = 3 [ (google.api.field_behavior) = OPTIONAL ];
 }
 
-// ListModelResponse represents a response for a list of models
-message ListModelResponse {
+// ListModelsResponse represents a response for a list of models
+message ListModelsResponse {
   // a list of Models
   repeated Model models = 1;
   // Next page token
@@ -364,9 +364,9 @@ message UnpublishModelResponse {
   Model model = 1;
 }
 
-// ListModelInstanceRequest represents a request to list all instances of a
+// ListModelInstancesRequest represents a request to list all instances of a
 // model
-message ListModelInstanceRequest {
+message ListModelInstancesRequest {
   // The name of the model whose instances we'd like to list.
   // e.g., "models/yolov4"
   string parent = 1 [
@@ -387,8 +387,8 @@ message ListModelInstanceRequest {
   optional View view = 4 [ (google.api.field_behavior) = OPTIONAL ];
 }
 
-// ListModelInstanceResponse represents a response for a list of model instances
-message ListModelInstanceResponse {
+// ListModelInstancesResponse represents a response for a list of model instances
+message ListModelInstancesResponse {
   // a list of Model instances
   repeated ModelInstance instances = 1;
   // Next page token
@@ -685,9 +685,9 @@ message GetModelOperationResponse {
   google.longrunning.Operation operation = 1;
 }
 
-// ListModelOperationRequest represents a request to list all model operations
+// ListModelOperationsRequest represents a request to list all model operations
 // including deploy and undeploy
-message ListModelOperationRequest {
+message ListModelOperationsRequest {
   // Page size: the maximum number of resources to return. The service may
   // return fewer than this value. If unspecified, at most 10 operations will be
   // returned. The maximum value is 100; values above 100 will be coereced to
@@ -703,9 +703,9 @@ message ListModelOperationRequest {
   optional View view = 4 [ (google.api.field_behavior) = OPTIONAL ];
 }
 
-// ListModelOperationResponse represents a response for a list of model
+// ListModelOperationsResponse represents a response for a list of model
 // operations including deploy and undeploy
-message ListModelOperationResponse {
+message ListModelOperationsResponse {
   // a list of model operations
   repeated google.longrunning.Operation operations = 1;
   // Next page token
@@ -726,8 +726,8 @@ message CancelModelOperationResponse {}
 
 // ========== Admin endpoints
 
-// ListModelAdminRequest represents a request to list all models from all users by admin
-message ListModelAdminRequest {
+// ListModelsAdminRequest represents a request to list all models from all users by admin
+message ListModelsAdminRequest {
   // Page size: the maximum number of resources to return. The service may
   // return fewer than this value. If unspecified, at most 10 models will be
   // returned. The maximum value is 100; values above 100 will be coereced to
@@ -741,8 +741,8 @@ message ListModelAdminRequest {
   optional View view = 3 [ (google.api.field_behavior) = OPTIONAL ];
 }
 
-// ListModelAdminResponse represents a response for a list of models
-message ListModelAdminResponse {
+// ListModelsAdminResponse represents a response for a list of models
+message ListModelsAdminResponse {
   // a list of Models
   repeated Model models = 1;
   // Next page token

vdp/model/v1alpha/model.proto

@@ -87,9 +87,9 @@ enum View {
   VIEW_FULL = 2;
 }
 
-// ListModelDefinitionRequest represents a request to list all supported model
+// ListModelDefinitionsRequest represents a request to list all supported model
 // definitions
-message ListModelDefinitionRequest {
+message ListModelDefinitionsRequest {
   // Page size: the maximum number of resources to return. The service may
   // return fewer than this value. If unspecified, at most 10 ModelDefinitions
   // will be returned. The maximum value is 100; values above 100 will be
@@ -104,9 +104,9 @@ message ListModelDefinitionRequest {
   optional View view = 3 [ (google.api.field_behavior) = OPTIONAL ];
 }
 
-// ListModelDefinitionResponse represents a response to list all supported model
+// ListModelDefinitionsResponse represents a response to list all supported model
 // definitions
-message ListModelDefinitionResponse {
+message ListModelDefinitionsResponse {
   // a list of ModelDefinition instances
   repeated ModelDefinition model_definitions = 1;
   // Next page token