Skip to content

Commit 370102c

Browse files
authored
Merge pull request #574 from instructlab/rm-ci-slack-results
ci: stop reporting results to slack
2 parents 5deaecf + 14e66f7 commit 370102c

File tree

2 files changed

+3
-32
lines changed

2 files changed

+3
-32
lines changed

.github/workflows/e2e-nvidia-l40s-x4.yml

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -262,34 +262,6 @@ jobs:
262262
env:
263263
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
264264

265-
- name: Post job results to Slack if the workflow failed
266-
if: failure() && steps.check_pr.outputs.is_pr == 'false'
267-
id: slack-report-failure
268-
uses: slackapi/slack-github-action@b0fa283ad8fea605de13dc3f449259339835fc52 # v2.1.0
269-
with:
270-
token: ${{ secrets.SON_OF_JEEVES_TOKEN }}
271-
method: chat.postMessage
272-
payload: |
273-
# Slack channel id, channel name, or user id to post message.
274-
# See also: https://api.slack.com/methods/chat.postMessage#channels
275-
# You can pass in multiple channels to post to by providing a comma-delimited list of channel IDs.
276-
channel: 'e2e-ci-results'
277-
text: "*e2e-nvidia-l40s-x4* job in *${{ github.repository }}* running on branch `${{ steps.check_pr.outputs.pr_or_branch }}` completed *with failures* :meow_sad-rain: | ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
278-
279-
- name: Post job results to Slack if the workflow succeeded
280-
if: success() && steps.check_pr.outputs.is_pr == 'false'
281-
id: slack-report-success
282-
uses: slackapi/slack-github-action@b0fa283ad8fea605de13dc3f449259339835fc52 # v2.1.0
283-
with:
284-
token: ${{ secrets.SON_OF_JEEVES_TOKEN }}
285-
method: chat.postMessage
286-
payload: |
287-
# Slack channel id, channel name, or user id to post message.
288-
# See also: https://api.slack.com/methods/chat.postMessage#channels
289-
# You can pass in multiple channels to post to by providing a comma-delimited list of channel IDs.
290-
channel: 'e2e-ci-results'
291-
text: "*e2e-nvidia-l40s-x4* job in *${{ github.repository }}* running on branch `${{ steps.check_pr.outputs.pr_or_branch }}` completed *successfully* :meow_party: | ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
292-
293265
- name: Send Discord notification for failure
294266
if: failure() && steps.check_pr.outputs.is_pr == 'false'
295267
uses: sarisia/actions-status-discord@5ddd3b114a98457dd80a39b2f00b6a998cd69008 # v1.15.3

docs/ci.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,14 @@ For more details about the E2E scripts themselves, see [the InstructLab Core doc
3131

3232
### Current E2E Jobs
3333

34-
| Name | T-Shirt Size | Runner Host | Instance Type | OS | GPU Type | Script | Flags | Runs when? | Slack/Discord reporting? |
34+
| Name | T-Shirt Size | Runner Host | Instance Type | OS | GPU Type | Script | Flags | Runs when? | Discord reporting? |
3535
| --- | --- | --- | --- | --- | --- | --- | --- | --- | --- |
3636
| [`e2e-nvidia-l40s-x4.yml`](https://github.com/instructlab/training/blob/main/.github/workflows/e2e-nvidia-l40s-x4.yml) | Large | AWS |[`g6e.12xlarge`](https://aws.amazon.com/ec2/instance-types/g6e/) | CentOS Stream 9 | 4 x NVIDIA L40S w/ 48 GB VRAM (192 GB) | `e2e-ci.sh` | `l` | Manually by Maintainers, Automatically against `main` branch at 4PM UTC | Yes |
3737

38-
### Discord/Slack reporting
38+
### Discord reporting
3939

40-
Some E2E jobs send their results to the channel `#e2e-ci-results` via the `Son of Jeeves` bot in both Discord and Slack. You can see which jobs currently have reporting via the "Current E2E Jobs" table above.
40+
Some E2E jobs send their results to the channel `#e2e-ci-results` via the `Son of Jeeves` bot in Discord. You can see which jobs currently have reporting via the "Current E2E Jobs" table above.
4141

42-
In Slack, this has been implemented via [the official Slack GitHub Action](https://github.com/slackapi/slack-github-action?tab=readme-ov-file#technique-2-slack-app).
4342
In Discord, we use [actions/actions-status-discord](https://github.com/sarisia/actions-status-discord) and the built-in channel webhooks feature.
4443

4544
### Triggering an E2E job via GitHub Web UI

0 commit comments

Comments
 (0)