Skip to content

Commit 512c06c

Browse files
fixing shellcheck
Signed-off-by: greg pereira <[email protected]>
1 parent 68ad8c1 commit 512c06c

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

api-server/rhelai-install/rhelai-install.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@ set -o pipefail
1010

1111
### installations
1212

13-
if [ -z $(command -v git) ]; then
13+
if [ -z "$(command -v git)" ]; then
1414
echo "please make sure \`git\` is installed."
1515
exit 1
1616
fi
1717

18-
if [ -z $(command -v go) ]; then
18+
if [ -z "$(command -v go)" ]; then
1919
echo "\`go\` is not installed, installing."
2020
./install-go.sh
2121
fi
@@ -25,7 +25,7 @@ if [ -z "$TAXONOMY_PATH" ]; then
2525
export TAXONOMY_PATH="$HOME/.local/share/instructlab/taxonomy"
2626
fi
2727

28-
if [ ! -d "$TAXONOMY_PATH"]; then
28+
if [ ! -d "$TAXONOMY_PATH" ]; then
2929
echo "\$TAXONOMY_PATH was set as $TAXONOMY_PATH, but path does not exist."
3030
exit 1
3131
fi
@@ -43,8 +43,8 @@ go build -o ilab-api-router
4343

4444
CUDA_FLAG=""
4545

46-
if [ $(command -v nvcc) ] && [ -n $(nvcc --version) ]; then
46+
if [ "$(command -v nvcc)" ] && [ -n "$(nvcc --version)" ]; then
4747
CUDA_FLAG="--cuda"
4848
fi
4949

50-
./ilab-api-router --taxonomy-path $TAXONOMY_PATH $CUDA_FLAG --rhelai --vllm
50+
./ilab-api-router --taxonomy-path "$TAXONOMY_PATH" $CUDA_FLAG --rhelai --vllm

0 commit comments

Comments
 (0)