Skip to content

Commit d16c20f

Browse files
Merge pull request #522 from vishnoianil/dryrun-api-server
Do no run upload-s3-package on pull_request event
2 parents bc9f7f8 + ca782d7 commit d16c20f

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

.github/workflows/api-server.yml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ jobs:
6464
defaults:
6565
run:
6666
working-directory: api-server
67-
6867
steps:
6968
- uses: actions/checkout@v4
7069
- name: Set up Go
@@ -93,8 +92,7 @@ jobs:
9392
contents: read
9493
runs-on: ubuntu-latest
9594
environment: registry-creds
96-
# if: github.ref == 'refs/heads/main'
97-
95+
if: ${{ github.event_name == 'push' }}
9896
steps:
9997
- name: download tar.gz binary artifacts
10098
uses: actions/download-artifact@v4
@@ -115,10 +113,3 @@ jobs:
115113
- name: copy binaries to s3
116114
run: |
117115
aws s3 sync dist/packages s3://instructlab-ui/apiserver
118-
119-
build-workflow-complete:
120-
needs: ["build-packages", "upload-s3-packages"]
121-
runs-on: ubuntu-latest
122-
steps:
123-
- name: Build Complete
124-
run: echo "Build Complete"

api-server/jobs.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ func (srv *ILabServer) getJob(jobID string) (*Job, error) {
120120
j.EndTime = &t
121121
}
122122
}
123+
123124
return &j, nil
124125
}
125126

0 commit comments

Comments
 (0)