CRs

Author: kristofnemere

apps/parent/src/main/java/com/instructure/parentapp/di/feature/GradesModule.kt

@@ -20,10 +20,10 @@ package com.instructure.parentapp.di.feature
 import com.instructure.canvasapi2.apis.AssignmentAPI
 import com.instructure.canvasapi2.apis.CourseAPI
 import com.instructure.canvasapi2.managers.graphql.CustomGradeStatusesManager
-import com.instructure.canvasapi2.models.Course
 import com.instructure.pandautils.features.grades.GradesRepository
 import com.instructure.pandautils.features.grades.GradesViewModelBehavior
 import com.instructure.parentapp.features.grades.ParentGradesRepository
+import com.instructure.parentapp.features.grades.ParentGradesViewModelBehavior
 import com.instructure.parentapp.util.ParentPrefs
 import dagger.Module
 import dagger.Provides
@@ -46,10 +46,6 @@ class GradesModule {
 
     @Provides
     fun provideGradesViewModelBehavior(): GradesViewModelBehavior {
-        return object : GradesViewModelBehavior {
-            override fun isWhatIfGradingEnabled(course: Course): Boolean {
-                return course.settings?.restrictQuantitativeData != true
-            }
-        }
+        return ParentGradesViewModelBehavior()
     }
 }

apps/parent/src/main/java/com/instructure/parentapp/features/grades/ParentGradesViewModelBehavior.kt

@@ -0,0 +1,28 @@
+/*
+ * Copyright (C) 2025 - present Instructure, Inc.
+ *
+ *     This program is free software: you can redistribute it and/or modify
+ *     it under the terms of the GNU General Public License as published by
+ *     the Free Software Foundation, version 3 of the License.
+ *
+ *     This program is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ *     You should have received a copy of the GNU General Public License
+ *     along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+package com.instructure.parentapp.features.grades
+
+import com.instructure.canvasapi2.models.Course
+import com.instructure.pandautils.features.grades.GradesViewModelBehavior
+
+class ParentGradesViewModelBehavior : GradesViewModelBehavior {
+
+    override fun isWhatIfGradingEnabled(course: Course): Boolean {
+        return false
+    }
+}

libs/pandares/src/main/res/values/strings.xml

@@ -1941,14 +1941,14 @@
     <string name="gradeLockedContentDescription">Grade locked</string>
     <string name="gradesRefreshFailed">Failed to refresh grades</string>
     <string name="showWhatIfScore">Show What-if Score</string>
-    <string name="editWhatIfScore">Edit what-if score</string>
+    <string name="editWhatIfScore">Edit what-if Score</string>
     <string name="editWhatIfScoreTitle">Edit What-if Score</string>
     <string name="whatIfScoreLabel">What-if</string>
     <string name="whatIfScoreCurrentGraded">Score %1$.0f out of %2$.0f</string>
     <string name="whatIfScoreCurrentUngraded">Not graded, max score %.0f</string>
     <string name="whatIfScoreDisplay">What-if: %s</string>
     <string name="gradesBasedOnGradedAndWhatIf">Based on graded assignments, and What-if Score</string>
-    <string name="clearWhatIfScore">Clear what-if score</string>
+    <string name="clearWhatIfScore">Clear what-if Score</string>
     <string name="chooseACourseToMessage">Choose a course to message</string>
     <string name="regardingHiddenMessage">Regarding: %1$s, %2$s</string>
     <string name="regardingHiddenMessageWithAssignmentPrefix">Regarding: %1$s, Assignment - %2$s</string>

libs/pandautils/src/main/java/com/instructure/pandautils/features/grades/GradesScreen.kt

@@ -114,6 +114,7 @@ import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
 import androidx.compose.ui.unit.sp
 import com.instructure.canvasapi2.utils.ContextKeeper
+import com.instructure.canvasapi2.utils.NumberHelper
 import com.instructure.pandautils.R
 import com.instructure.pandautils.compose.CanvasTheme
 import com.instructure.pandautils.compose.NoRippleInteractionSource
@@ -133,6 +134,7 @@ import com.instructure.pandautils.features.grades.gradepreferences.GradePreferen
 import com.instructure.pandautils.utils.DisplayGrade
 import com.instructure.pandautils.utils.announceAccessibilityText
 import com.instructure.pandautils.utils.drawableId
+import com.instructure.pandautils.utils.orDefault
 import kotlinx.coroutines.android.awaitFrame
 import kotlinx.coroutines.launch
 
@@ -1021,7 +1023,9 @@ fun AssignmentItem(
                                     )
                                     .padding(horizontal = 4.dp)
                             ) {
-                                val whatIfScoreText = "${uiState.whatIfScore.toInt()}/${uiState.maxScore?.toInt()}"
+                                val whatIfScore = NumberHelper.formatDecimal(uiState.whatIfScore, 2, true)
+                                val maxScore = NumberHelper.formatDecimal(uiState.maxScore.orDefault(), 2, true)
+                                val whatIfScoreText = "$whatIfScore/$maxScore"
                                 Text(
                                     text = stringResource(
                                         id = R.string.whatIfScoreDisplay,