Fix Student QA V5 - Part 2 - 7. finding (K5 homeroom dashboard big gap and schedule page bottom gap issue.)

Author: kdeakinstructure

apps/student/src/main/java/com/instructure/student/mobius/elementary/ElementaryDashboardFragment.kt

@@ -20,6 +20,8 @@ import android.os.Bundle
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
+import androidx.core.view.ViewCompat
+import androidx.core.view.WindowInsetsCompat
 import com.google.android.material.tabs.TabLayout
 import com.instructure.canvasapi2.models.CanvasContext
 import com.instructure.interactions.router.Route
@@ -33,7 +35,6 @@ import com.instructure.pandautils.features.elementary.resources.ResourcesFragmen
 import com.instructure.pandautils.features.elementary.schedule.pager.SchedulePagerFragment
 import com.instructure.pandautils.utils.Const
 import com.instructure.pandautils.utils.ParcelableArg
-import com.instructure.pandautils.utils.applyBottomSystemBarInsets
 import com.instructure.pandautils.utils.applyTopSystemBarInsets
 import com.instructure.pandautils.utils.isTablet
 import com.instructure.pandautils.utils.makeBundle
@@ -84,7 +85,24 @@ class ElementaryDashboardFragment : ParentFragment() {
         super.onViewCreated(view, savedInstanceState)
 
         dashboardPager.adapter = ElementaryDashboardPagerAdapter(fragments, childFragmentManager)
-        dashboardPager.applyBottomSystemBarInsets()
+
+        // Consume bottom insets so child fragments don't apply them
+        // The Canvas bottom navigation bar handles bottom spacing at the activity level
+        ViewCompat.setOnApplyWindowInsetsListener(dashboardPager) { view, insets ->
+            val navigationBars = insets.getInsets(WindowInsetsCompat.Type.navigationBars())
+            WindowInsetsCompat.Builder(insets)
+                .setInsets(
+                    WindowInsetsCompat.Type.navigationBars(),
+                    androidx.core.graphics.Insets.of(
+                        navigationBars.left,
+                        navigationBars.top,
+                        navigationBars.right,
+                        0 // Consume bottom insets
+                    )
+                )
+                .build()
+        }
+
         dashboardTabLayout.addOnTabSelectedListener(object : TabLayout.OnTabSelectedListener {
             override fun onTabReselected(tab: TabLayout.Tab?) = Unit
 

libs/pandautils/src/main/java/com/instructure/pandautils/features/elementary/schedule/pager/SchedulePagerFragment.kt

@@ -21,13 +21,16 @@ import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
 import androidx.constraintlayout.widget.ConstraintSet
+import androidx.core.view.ViewCompat
+import androidx.core.view.WindowInsetsCompat
+import androidx.core.view.updatePadding
 import androidx.fragment.app.Fragment
-import com.instructure.pandautils.base.BaseCanvasFragment
 import androidx.fragment.app.viewModels
 import androidx.lifecycle.LiveData
 import androidx.lifecycle.MutableLiveData
 import androidx.viewpager2.adapter.FragmentStateAdapter
 import androidx.viewpager2.widget.ViewPager2
+import com.instructure.pandautils.base.BaseCanvasFragment
 import com.instructure.pandautils.databinding.FragmentSchedulePagerBinding
 import com.instructure.pandautils.features.elementary.schedule.ScheduleFragment
 import com.instructure.pandautils.utils.isAccessibilityEnabled
@@ -57,6 +60,30 @@ class SchedulePagerFragment : BaseCanvasFragment() {
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
 
+        // Consume bottom insets for schedulePager so child fragments don't apply them
+        // The controls section handles bottom spacing
+        ViewCompat.setOnApplyWindowInsetsListener(binding.schedulePager) { view, insets ->
+            val navigationBars = insets.getInsets(WindowInsetsCompat.Type.navigationBars())
+            WindowInsetsCompat.Builder(insets)
+                .setInsets(
+                    WindowInsetsCompat.Type.navigationBars(),
+                    androidx.core.graphics.Insets.of(
+                        navigationBars.left,
+                        navigationBars.top,
+                        navigationBars.right,
+                        0 // Consume bottom insets
+                    )
+                )
+                .build()
+        }
+
+        // Apply bottom system bar insets to controls (Previous/Next Week buttons)
+        ViewCompat.setOnApplyWindowInsetsListener(binding.controls) { view, insets ->
+            val navigationBars = insets.getInsets(WindowInsetsCompat.Type.navigationBars())
+            view.updatePadding(bottom = navigationBars.bottom)
+            insets
+        }
+
         viewModel.data.observe(viewLifecycleOwner, { schedulePagerViewData ->
             schedulePagerViewData?.let {
                 binding.schedulePager.adapter = object : FragmentStateAdapter(this@SchedulePagerFragment) {