Fix Student QA V5 - Part 2 - 4. finding (ToDo list Preferences page gap at the bottom issue.)

Author: kdeakinstructure

libs/pandautils/src/main/java/com/instructure/pandautils/compose/composables/FullScreenDialog.kt

@@ -20,14 +20,15 @@ package com.instructure.pandautils.compose.composables
 import android.view.WindowManager
 import androidx.compose.foundation.layout.Box
 import androidx.compose.foundation.layout.WindowInsets
+import androidx.compose.foundation.layout.asPaddingValues
 import androidx.compose.foundation.layout.displayCutout
 import androidx.compose.foundation.layout.fillMaxSize
 import androidx.compose.foundation.layout.padding
 import androidx.compose.foundation.layout.systemBars
 import androidx.compose.foundation.layout.union
-import androidx.compose.foundation.layout.windowInsetsPadding
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.platform.LocalLayoutDirection
 import androidx.compose.ui.platform.LocalView
 import androidx.compose.ui.res.dimensionResource
 import androidx.compose.ui.unit.dp
@@ -60,10 +61,23 @@ fun FullScreenDialog(
             // Enable drawing behind system bars
             addFlags(WindowManager.LayoutParams.FLAG_LAYOUT_IN_SCREEN)
             addFlags(WindowManager.LayoutParams.FLAG_LAYOUT_NO_LIMITS)
+
+            // Ensure the window extends to full screen height
+            setLayout(
+                WindowManager.LayoutParams.MATCH_PARENT,
+                WindowManager.LayoutParams.MATCH_PARENT
+            )
         }
+        val layoutDirection = LocalLayoutDirection.current
+        val insets = WindowInsets.systemBars.union(WindowInsets.displayCutout).asPaddingValues()
         var modifier = Modifier
             .fillMaxSize()
-            .windowInsetsPadding(WindowInsets.systemBars.union(WindowInsets.displayCutout))
+            .padding(
+                top = insets.calculateTopPadding(),
+                start = insets.calculateLeftPadding(layoutDirection),
+                end = insets.calculateRightPadding(layoutDirection)
+                // Intentionally not applying bottom padding so content background extends behind navigation bar
+            )
         if (ApiPrefs.isMasquerading) {
             modifier = modifier.padding(
                 top = dimensionResource(R.dimen.masqueradeButtonSize),

libs/pandautils/src/main/java/com/instructure/pandautils/features/todolist/filter/ToDoFilterScreen.kt

@@ -17,11 +17,15 @@ package com.instructure.pandautils.features.todolist.filter
 
 import androidx.compose.foundation.clickable
 import androidx.compose.foundation.layout.Column
+import androidx.compose.foundation.layout.PaddingValues
 import androidx.compose.foundation.layout.Row
 import androidx.compose.foundation.layout.Spacer
+import androidx.compose.foundation.layout.WindowInsets
+import androidx.compose.foundation.layout.asPaddingValues
 import androidx.compose.foundation.layout.defaultMinSize
 import androidx.compose.foundation.layout.fillMaxSize
 import androidx.compose.foundation.layout.fillMaxWidth
+import androidx.compose.foundation.layout.navigationBars
 import androidx.compose.foundation.layout.padding
 import androidx.compose.foundation.layout.size
 import androidx.compose.foundation.layout.width
@@ -97,6 +101,7 @@ fun ToDoFilterScreen(
                 }
             )
         },
+        contentWindowInsets = WindowInsets(0, 0, 0, 0),
         modifier = modifier
     ) { padding ->
         ToDoFilterContent(
@@ -113,7 +118,11 @@ fun ToDoFilterContent(
     uiState: ToDoFilterUiState,
     modifier: Modifier = Modifier
 ) {
-    LazyColumn(modifier = modifier.testTag("ToDoFilterContent")) {
+    val navigationBarPadding = WindowInsets.navigationBars.asPaddingValues()
+    LazyColumn(
+        modifier = modifier.testTag("ToDoFilterContent"),
+        contentPadding = PaddingValues(bottom = navigationBarPadding.calculateBottomPadding())
+    ) {
         item {
             SectionHeader(title = stringResource(id = R.string.todoFilterVisibleItems))
         }